Git Product home page Git Product logo

xxhash-swift's Issues

XXH3 implementation out of date with xxHash 0.8.0

With xxHash v0.8.0, XXH3 is now stable (see https://github.com/Cyan4973/xxHash/releases/tag/v0.8.0).

Looking at the test vectors in this library, it looks as though it is out of sync with the latest tag. Is there a plan to upgrade?

For example, for xxHash3-64, for an empty input and zero-value seed we would expect a hash of 2D06800538D394C2.
https://github.com/Cyan4973/xxHash/blob/94e5f23e736f2bb67ebdf90727353e65344f9fc0/xxhsum.c#L1246

Instead the current implementation in this library returns 0000000000000000.

xxHash-Swift/Tests/xxHashTests/xxHashTests.swift

Line 464 in 1fbd877

XCTAssertEqual(XXH3.digest64Hex("").lowercased(), "0000000000000000")

Example code not working?

I am not sure if I am missing something, but I can't get the example code to work for the life of me. I guess I am supposed to use length instead of count, but then I also cannot access the subscript of the NSData type. On the off chance that its an issue with the example code I am posting it here, but assistance would be appreciated if it is just me not understanding the code.

screen shot 2019-03-06 at 4 53 24 pm

Classes vs structs

Why using classes instead of Swift structs? Why not marking classes as final (turns on some optimizations)?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.