dailinjie / jsload Goto Github PK

There is bug in function loadScript(version 0.9):
after returning from function loadNext() script tries to load non existing file

line 223:if ( (iteration + 1) > srcSetObj.srcToLoad.length ) loadNext();
should be 

223:if((iteration + 1) > srcSetObj.srcToLoad.length){loadNext();return;}

Hi Eric, this is a very nice piece of code.  We did have a couple issues, 
however, that we quickly patched.  Might not be the ideal fixes, but they 
work for our purposes.

1. Safari 3 was throwing several errors trying the load an "undefined" 
script.  I altered the createScriptEl function to check the url var before 
execution of the body. This issue also caused Chrome to crash. It iss 
possible that there is something in my code passing undefined to .load 
function, but so far I haven't seen any errors in IE or Firefox that 
validates any consistency.

   function createScriptEl(url, srcSetObj, iteration) {
            if (url != "undefined") {....

2.  Added a path property to the tag object to allow easy setting of a 
path variable without having to manually append it to the name property or 
depend on just 'http://' in the name string.

          In .getSrcToLoad prototype....

        if (tagName.indexOf("http://") > -1) {
            var filePath = tagName;
        } else if (tag.path) {
            var filePath = tag.path + tagName + '.js';
        }
        else {
            var filePath = (path ? path : "") + tagName + '.js';
        }


Regards,

Patrick Dillon
Integrify

What steps will reproduce the problem?
1. Run the test page

What is the expected output? What do you see instead?

Only 20 out of 24 tests will pass. The four executionAfterLoad tests fail.
Safari is returning an execution log of ["end of document","window
loaded","callback executed"], which is not a pattern we expect.

Please use labels and text to provide additional information.

What steps will reproduce the problem?
I've attached my setup of JSLoad and a screenshot of the output. if you dont 
mind taking a look. 
maybe i did something wrong.

What is the expected output? What do you see instead?
I want to load external scripts from Google AJAX Library. i've added the path 
configuration, but 
JSLoad still loads the version on my server.

What version of the product are you using? On what operating system?
i'm using JSLoad 0.9, i got it directly from the Downloads section. and i'm 
currently developing on 
Safari 4.0.5 and Firefox 3.6.2.

thx,
Rizky

What steps will reproduce the problem?
1. Try to access to javascript function in JSLoad.prototype.load callback
function

What is the expected output? What do you see instead?
I was enable to access to my namespace function, it's not in dom. However,
corresponing js is loaded 


What version of the product are you using? On what operating system?
Opera 9.63, Revision 5261, Plate-forme Mac OS X, System 10.5.6 

Please provide any additional information below.
---------------
Opera error:
ecmascript
http://localhost/~sebastien/nws/proxycachedns.html
Event thread: readystatechange
Error:
name: TypeError
message: Statement on line 14: Cannot convert undefined or null to Object
Backtrace:
  Line 14 of linked script
http://localhost/~sebastien/nws/modules/proxycachedns/proxycachedns-loader.js:
In function callbackLoaded
            Nws.Services.ProxyCacheDns.Demo.load(true);
  Line 175 of linked script
http://localhost/~sebastien/nws/libs/jsload/jsload.js: In function loadNext
                srcSetObj.callback();
  Line 253 of linked script
http://localhost/~sebastien/nws/libs/jsload/jsload.js
                    loadNext();
  Line 206 of linked script
http://localhost/~sebastien/nws/libs/jsload/jsload.js: In function scriptOnLoad
                        thisObj.loadScript(srcSetObj, iteration);
  ...
stacktrace:   ...  Line 175 of linked script
http://localhost/~sebastien/nws/libs/jsload/jsload.js: In function loadNext
                srcSetObj.callback();
  Line 253 of linked script
http://localhost/~sebastien/nws/libs/jsload/jsload.js
                    loadNext();
  Line 206 of linked script
http://localhost/~sebastien/nws/libs/jsload/jsload.js: In function scriptOnLoad
                        thisObj.loadScript(srcSetObj, iteration);
  ...

---------------

Loaded js files

Lié - ext-base.js
eval - Id du script: 192
Lié - ext-all.js
Lié - DomQuery.js
eval - Id du script: 196
Inline - Id du script: 197
Lié - jsload.js
Lié - modules.js
Lié - proxycachedns-loader.js -> jsload load is called here 
Lié - str.js
Lié - init.js
Lié - uri.js
Lié - thema.js
Lié - conv.js
Lié - comm.js
Lié - utils.js
Lié - cookie.js
Lié - ui.js
Lié - potreader.js
Lié - core.js
Lié - engine.js
eval - Id du script: 213
eval - Id du script: 214
Lié - proxycachedns.js
Lié - proxycachedns-ui.js
Lié - proxycachedns-demo.js


---------------
proxycachedns-loader.js code

Ext.onReady(function(){ // Called when dom is ready
    jsLoader.load(['proxycachedns-demo'], callbackLoaded);

    function callbackLoaded(){
        Nws.init({
            debugEnabled: true,
            exceptionCatchEnabled: false,
            useBrowserConsole: false
        });

        Nws.Services.ProxyCacheDns.Demo.load(true); // in proxycachedns-demo.js

        Nws.Ui.removeLoaderMask();
    }
});