The laravel-ga4-event-tracking from daikazu

Hi there 👋

I'm am a full stack developer mostly in the PHP world and love building apps in Laravel. I currently work as senior developer at a large promotional product company.

📈 Code::Stats

laravel-ga4-event-tracking's People

Contributors

Stargazers

Watchers

laravel-ga4-event-tracking's Issues

Missing user_id in SendEvent

src/GA4.php
Forgetting to make use of the userId set on line 47...

public function sendEvent(array $eventData): array
    {
        if (! $this->clientId && ! $this->clientId = session(config('ga4-event-tracking.client_id_session_key'))) {
            throw new MissingClientIdException;
        }

        $this->validateEvent($eventData);

        $response = Http::withOptions([
            'query' => [
                'measurement_id' => config('ga4-event-tracking.measurement_id'),
                'api_secret' => config('ga4-event-tracking.api_secret'),
            ],
        ])->post($this->getRequestUrl(), [
            'client_id' => $this->clientId,
            'events' => [$eventData],
        ]);

        if ($this->debugging) {
            return $response->json();
        }

        return [
            'status' => $response->successful(),
        ];
    }

Line 78 should get updated to...

        ])->post($this->getRequestUrl(), [
            'client_id' => $this->clientId,
            'user_id' => $this->userId,
            'events' => [$eventData],
        ]);

Lemme know if you need a PR or can just fix it yerself...

Recommend Projects