dahlb / ha_sense Goto Github PK

System Health details

unnecessary for this issue, I have already determined the root cause

Checklist

• I have enabled debug logging for my installation.
• I have filled out the issue template to the best of my ability.
• This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
• This issue is not a duplicate issue of currently previous issues..

Describe the issue

The integration generates a long line every couple of minutes for every enabled entity.

I have tracked this down to the following line:

The preceeding for loop does the same thing as the library does when this line is called, but the for loop correctly does it at the debug level. The line in question does the same thing at the info level, which is unnecessary. I recommend just removing the line in question that calls print_instance_wattages() as users will still be able to access that logging if they enable debug logging, and will not clutter their logs making it more difficult to troubleshoot issues unrelated to this integration.

Reproduction steps

1. install the integration
2. enable some entities provided by the integration
3. look at your logs

Debug logs

2023-09-27 10:25:05.014 INFO (SyncWorker_5) [root] Plug cph50 power output power: 0.0
2023-09-27 10:25:05.014 INFO (SyncWorker_5) [root] Plug terrarium lights power power: 93.0
2023-09-27 10:25:05.014 INFO (SyncWorker_5) [root] Plug korben port 1 poe power power: 7.64
2023-09-27 10:25:05.014 INFO (SyncWorker_5) [root] Plug korben port 2 poe power power: 6.13
2023-09-27 10:25:05.014 INFO (SyncWorker_5) [root] Plug korben port 3 poe power power: 3.46
2023-09-27 10:25:05.015 INFO (SyncWorker_5) [root] Plug omnilogic pool filter pump power power: 150.0
2023-09-27 10:27:05.015 INFO (SyncWorker_7) [root] Plug cph50 power output power: 0.0
2023-09-27 10:27:05.015 INFO (SyncWorker_7) [root] Plug terrarium lights power power: 93.0
2023-09-27 10:27:05.015 INFO (SyncWorker_7) [root] Plug korben port 1 poe power power: 7.64
2023-09-27 10:27:05.015 INFO (SyncWorker_7) [root] Plug korben port 2 poe power power: 6.02
2023-09-27 10:27:05.015 INFO (SyncWorker_7) [root] Plug korben port 3 poe power power: 3.51
2023-09-27 10:27:05.015 INFO (SyncWorker_7) [root] Plug omnilogic pool filter pump power power: 150.0
2023-09-27 10:29:05.017 INFO (SyncWorker_16) [root] Plug cph50 power output power: 0.0
2023-09-27 10:29:05.017 INFO (SyncWorker_16) [root] Plug terrarium lights power power: 92.7
2023-09-27 10:29:05.017 INFO (SyncWorker_16) [root] Plug korben port 1 poe power power: 7.64
2023-09-27 10:29:05.017 INFO (SyncWorker_16) [root] Plug korben port 2 poe power power: 6.18
2023-09-27 10:29:05.018 INFO (SyncWorker_16) [root] Plug korben port 3 poe power power: 3.94
2023-09-27 10:29:05.018 INFO (SyncWorker_16) [root] Plug omnilogic pool filter pump power power: 150.0

Diagnostics dump

No response

System Health details

System Information

Checklist

• I have enabled debug logging for my installation.
• I have filled out the issue template to the best of my ability.
• This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
• This issue is not a duplicate issue of currently previous issues..

Describe the issue

When enabling more than one device, the logs produce an error about the address already being in use. If multiple devices are already enabled when the integration first starts up (for example after restarting Home Assistant) things seem to be fine. It appears that every time you enable a device perhaps it tries to restart the SenseLink, but it does not stop the old one first, so port 9999 (appears to be the default in SenseLink code) is already in use.

Reproduction steps

1. Install ha_sense integration from HACS
2. Enable one of the added entities
3. Wait at least 30 seconds for the entity to fully enable
4. Enable a second entity
5. Wait at least 30 seconds for HA to attempt to enable the entity
6. Observe error in logs

Debug logs

I cannot include the entirety of the logs because it makes the bug report to long, the maximum is 65536 characters.  I will attach it to the issue.

home-assistant_ha_sense_2023-08-25T21-17-11.339Z.log

Diagnostics dump

No response