Git Product home page Git Product logo

Comments (7)

halalala222 avatar halalala222 commented on September 15, 2024 1

@yohamta Hi! I will try to work on this !

from dagu.

halalala222 avatar halalala222 commented on September 15, 2024

@yohamta What do you think? I think this is a good idea.

  1. Duplicate configurations can be managed by reconfiguring based on environment variables
  2. This can prevent the direct exposure of sensitive information

from dagu.

yohamta avatar yohamta commented on September 15, 2024

Thank you for submitting this issue and suggestions. I completely agree that this would be a valuable feature.

To implement this, we will need to make the following changes:

  1. We'll add support for environment variable expansion in the executor config for all executor types available the SSH executor.
  2. We'll ensure that the expanded values are not written back to the Node data, as these values contain sensitive information that shouldn't be stored in status files.

If you have any thoughts on this implementation plan or additional considerations, please feel free to share them.

from dagu.

yohamta avatar yohamta commented on September 15, 2024

Thank you @halalala222, please feel free to ask if there's any questions!

from dagu.

halalala222 avatar halalala222 commented on September 15, 2024

@yohamta add support for environment variable expansion in the executor config for all executor types available Is it necessary to add this environment variable to executors other than the SSH executor?

from dagu.

yohamta avatar yohamta commented on September 15, 2024

Hi @halalala222, I made a mistake earlier - we actually only need support for environment variable expansion in the SSH executor right now. Sorry for the confusion.

from dagu.

halalala222 avatar halalala222 commented on September 15, 2024

@yohamta Hi!!! Thank you ! I completed this issue in this PR

from dagu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.