Comments (6)
Taking a look
from dagu.
@zph Thank you very much for the thorough investigation! This is extremely helpful. I will take a look shortly.
from dagu.
To determine if it's related to #602 , I checked out the commit right before that PR's merge (fdcc93a):
test script (added second step in case this is about the ${})
params: commit=1
tags: fix🐞
steps:
- name: step1
command: bash
script: |
echo ${commit}
export
- name: step2
command: bash
script: |
echo $commit $1
export
The output of step 1 is:
"1"
.... (unrelated exported vars)
declare -x commit="\"1\""
Then I checked the tip of main (a20bd1d) and using same dag, I can reproduce your bug report:
<both the echo of commit is missing and the declare -x commit= are missing>
Then I run the commit where #602 was merged in (9ef8153)
The output is:
1
declare -x commit="1"
Summary
Pre #602 : it output commit=""1""
Immediately Post #602: it output commit="1"
Now: it doesn't output anything
In none of the cases does it explicitly 1="\"commit=123"
Finding
- commit=1 being exported regressed after #602 landed
- 1="commit=123" is not showing up before or after
Next Step
I'll git bisect to find where this changed after 602 landed.
from dagu.
Using git bisect:
git bisect start
git bisect good 9ef8153
git bisect bad a20bd1d
git bisect bad
git bisect good
I find the following:
e78459b is the first bad commit which looks like part of a large refactor.
from dagu.
@yohamta Can you please take a look since you know the code in the refactor?
from dagu.
The issue has been resolved in v1.14.2
. Sorry for any inconvenience this may have caused. I greatly appreciate the support provided in helping to fix the problem. Thank you very much!
from dagu.
Related Issues (20)
- Update File Location to Follow XDG Standards
- formatting of error text in web ui is not very noticeable HOT 1
- (ux) Long params in yaml template lead to being unable to Start and click Confirm HOT 3
- How to call a local Docker image? HOT 4
- Allow complex `precondition` conditions
- (bug) Params and Env do not produce identical outputs HOT 1
- (feature) Add toggle to allow auto-scroll forward of dagu logs
- API dag "retry" POST request hangs until job completion
- Docker executor does not propagate exit code
- Docker executor does not propagate stderr output
- Update actions/cache from v3 to v4
- Docker container not being removed after workflow is cancelled
- Invalid example of docker executor with volumes
- schedule is not executed according to the schedule
- Log display on very large logs from Dagu takes minutes to load in browser without clear indication it will work HOT 1
- error reading params while running it from web/API endpoint HOT 6
- DAG validation with JSON schema in YAML editor HOT 2
- Add Pagination Parameters to DAG List API to limit the response HOT 8
- Fix HTTP_HandleCancel in TestAgent_HandleHTTP was a flakey test
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dagu.