Git Product home page Git Product logo

Comments (2)

maxfirman avatar maxfirman commented on July 3, 2024

Here is a straightforward way to reproduce:

  1. Bootstrap a new project with dagster project scaffold
  2. Copy the following into the assets.py
from dagster import AssetKey, SourceAsset, asset, AssetSpec, external_assets_from_specs

# SourceAsset is fine with a hyphen
my_source_asset = SourceAsset(key=AssetKey(["with-hyphen", "my_source_asset"]))


# Asset is fine with a hyphen
@asset(key=AssetKey(["with-hyphen", "my_asset"]))
def my_asset():
    return [1]


# External asset throws a DagsterInvalidDefinitionError with a hyphen in Dagster 1.6.9 and 1.6.10.
my_external_asset = AssetSpec(["with-hyphen", "my_external_asset"])

external_assets = external_assets_from_specs([my_external_asset])
  1. Run dagster dev

from dagster.

garethbrickman avatar garethbrickman commented on July 3, 2024

Thanks so much for root-causing this and creating a fix PR! I will triage to our engineering team for review 👍

from dagster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.