Comments (19)
Hey folks, I pulled down the sample above (thank you for the clear repro!) and loaded it up, but I'm not able to reproduce the UI hanging on the latest master
branch. I tried opening/closing the asset groups, etc. We did update Dagre in the last two weeks, so it's possible that impacted this behavior. I'm going to revert that dagre upgrade and see if this repro'd with the old version.
![image](https://private-user-images.githubusercontent.com/1037212/318961667-bd3e4e92-b5e6-4cdb-a3d1-91b77682abab.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE0MDUyNDIsIm5iZiI6MTcyMTQwNDk0MiwicGF0aCI6Ii8xMDM3MjEyLzMxODk2MTY2Ny1iZDNlNGU5Mi1iNWU2LTRjZGItYTNkMS05MWI3NzY4MmFiYWIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTlUMTYwMjIyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjEzMDRjN2YwYTMzOTU0YjM0NTg5YjlmNmM3ZDhhODE5YjU1ODFkYTFkM2Q5MDNkMmRhM2MyNzQ5YmIzZGQxMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.YxW9AI9lUbQWcKJG0EOTV5do8wGPdvJCLnT4dzdrSHY)
from dagster.
Hey @bengotow
We did update Dagre in the last two weeks, so it's possible that impacted this behavior. I'm going to revert that dagre upgrade and see if this repro'd with the old version.
Was there any change in the UI behavior after reverting?
from dagster.
I uninstalled and re-installed dagster
, dagster-webserver
, and dagster-pandas
and the problem was resolved.
from dagster.
Unfortunately, in the test I ran before closing the issue I used the wrong dependency table (not the one I provided for reproduction when I opened the issue). Usig the proper data set the problem seems to have persisted through the version upgrades.
from dagster.
Hi @cohenj20, We're aware of an issue with dagre (the layout library we use) and are trying to figure out how to mitigate it. For now the best I can offer is a work-around. If you update the URl to be /asset-groups?expanded=fake
(The key here is the expanded=fake
) this will reset all of the groups to closed. The issue only happens when certain combinations of groups are open so try not to open all of the groups at once.
from dagster.
I did what you suggested, however the UI still hangs. I try to chnge the URL to http://127.0.0.1:3000/asset-groups?expanded=fake
but it changes directly to http://127.0.0.1:3000/asset-groups?expanded=fake&open-nodes%5B%5D=dagster_project&open-nodes%5B%5D=dagster_project%3Aetl&open-nodes%5B%5D=dagster_project%3Adbo&open-nodes%5B%5D=dagster_project%3Areport&open-nodes%5B%5D=dagster_project%3Ainterface&open-nodes%5B%5D=dagster_project%3Alive
.
What could be the reason that in @bengotow 's environment the problem didn't present itself?
from dagster.
@cohenj20 Try /asset-groups?expanded=fake&open-nodes%5B%5D=fake
from dagster.
@salazarm No dice :/
I also tried creating a fresh dagster project, but it still hangs.
from dagster.
@salazarm I may have discovered something...
I was messing around with which combinations of asset groups cause the issue, and I noticed that if the report
asset group is selected, even if it's the only asset group selected, the UI hangs. As long as report
is unselected, all assets display instantly on the graph.
Update: This makes sense, on second thought, as the sum of assets in report
is more than all of the others combined.
from dagster.
@cohenj20 Do you see any errors in the developer console? If so can you share them here
from dagster.
@salazarm I do not see anything.
from dagster.
Would you be open to a zoom call so I can take a look? Keen on getting to the bottom of this.
from dagster.
I was messing around with which combinations of asset groups cause the issue, and I noticed that if the report asset group is selected, even if it's the only asset group selected, the UI hangs. As long as report is unselected, all assets display instantly on the graph.
I will pull on this thread
from dagster.
@salazarm If we can do it in an hour, sure. I need to step away for a bit.
from dagster.
@cohenj20 Yes that would work for me. Feel free to pop into https://meet.google.com/zje-xrev-vig?hs=122&authuser=0, I'll be waiting in there.
from dagster.
@cohenj20 I believe the issue you're facing is that the screen just looks blank? Correct? If so, I think there isn't actually a bug, it's just the default zooming took you to a spot where there where no assets. Try clicking on an asset in the sidebar to see if it zooms you to it.
from dagster.
For visibility, on the zoom call @salazarm and I confirmed there was the following error in the developer console:
Uncaught DOMException: Failed to execute 'importScripts' on 'WorkerGlobalScope': The script at 'http://127.0.0.1:3000/_next/static/chunks/framework-d6095a5336d3e425.js' failed to load.
at __webpack_require__.f.i (http://127.0.0.1:3000/_next/static/chunks/358.85428c524e2522c9.js:1:2431)
at http://127.0.0.1:3000/_next/static/chunks/358.85428c524e2522c9.js:1:1317
at Array.reduce (<anonymous>)
at __webpack_require__.e (http://127.0.0.1:3000/_next/static/chunks/358.85428c524e2522c9.js:1:1265)
at Array.map (<anonymous>)
at __webpack_require__.x (http://127.0.0.1:3000/_next/static/chunks/358.85428c524e2522c9.js:1:2853)
at http://127.0.0.1:3000/_next/static/chunks/358.85428c524e2522c9.js:1:2935
at http://127.0.0.1:3000/_next/static/chunks/358.85428c524e2522c9.js:1:2939
from dagster.
This will be fixed by #19046
from dagster.
#21129 *
from dagster.
Related Issues (20)
- ForwardRef._evaluate() missing 1 required keyword-only argument: 'recursive_guard' HOT 5
- Nested Resources in Jobs result in CheckError HOT 1
- Deleting materialization history in Lesson 8: Creating a Partition
- UnicodeDecodeError in -w mode, versions 1.6.4 to 1.7.13 HOT 2
- Lesson 8: ImportError: cannot import name 'utc_datetime_from_timestamp' from 'dagster._utils' HOT 1
- The dagster-pandera integration cannot handle `Annotated` types
- Dagster daemon heartbeat randomly stops HOT 2
- Dagster-slack is missing py.typed marker
- Examples for k8s configuration
- dagster-dbt : unable to load dbt project of an dbt-teradata adapter (when database is None in manifest.json) HOT 2
- Asset check `@asset_check` docstring not loaded as description
- asset check cannot load an asset that has a prefix
- Implement PipesCloudWatchMessageReader
- Error in "Customizing your Kubernetes Deployment"
- Config field descriptions not loading from attribute docstrings HOT 1
- Automatic pruning for `TimeWindowPartitionsDefinition` HOT 2
- materializable looker assets
- error with 1.7.14 : 'AssetSpecWithPartitionsDef' object has no attribute 'auto_materialize_policy'
- Add a Dagster run status for warnings. HOT 2
- Enabling dbt to fetch row count data causes job failures to go unreported. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dagster.