UI hangs rendering Global Asset Lineage of only 200 assets about dagster HOT 19 CLOSED

Hey folks, I pulled down the sample above (thank you for the clear repro!) and loaded it up, but I'm not able to reproduce the UI hanging on the latest master branch. I tried opening/closing the asset groups, etc. We did update Dagre in the last two weeks, so it's possible that impacted this behavior. I'm going to revert that dagre upgrade and see if this repro'd with the old version.

from dagster.

Hey @bengotow

We did update Dagre in the last two weeks, so it's possible that impacted this behavior. I'm going to revert that dagre upgrade and see if this repro'd with the old version.

Was there any change in the UI behavior after reverting?

from dagster.

I uninstalled and re-installed dagster, dagster-webserver, and dagster-pandas and the problem was resolved.

from dagster.

Unfortunately, in the test I ran before closing the issue I used the wrong dependency table (not the one I provided for reproduction when I opened the issue). Usig the proper data set the problem seems to have persisted through the version upgrades.

from dagster.

Hi @cohenj20, We're aware of an issue with dagre (the layout library we use) and are trying to figure out how to mitigate it. For now the best I can offer is a work-around. If you update the URl to be /asset-groups?expanded=fake (The key here is the expanded=fake) this will reset all of the groups to closed. The issue only happens when certain combinations of groups are open so try not to open all of the groups at once.

from dagster.

I did what you suggested, however the UI still hangs. I try to chnge the URL to http://127.0.0.1:3000/asset-groups?expanded=fake but it changes directly to http://127.0.0.1:3000/asset-groups?expanded=fake&open-nodes%5B%5D=dagster_project&open-nodes%5B%5D=dagster_project%3Aetl&open-nodes%5B%5D=dagster_project%3Adbo&open-nodes%5B%5D=dagster_project%3Areport&open-nodes%5B%5D=dagster_project%3Ainterface&open-nodes%5B%5D=dagster_project%3Alive.

What could be the reason that in @bengotow 's environment the problem didn't present itself?

from dagster.

@cohenj20 Try /asset-groups?expanded=fake&open-nodes%5B%5D=fake

from dagster.

@salazarm No dice :/

I also tried creating a fresh dagster project, but it still hangs.

from dagster.

@salazarm I may have discovered something...

I was messing around with which combinations of asset groups cause the issue, and I noticed that if the report asset group is selected, even if it's the only asset group selected, the UI hangs. As long as report is unselected, all assets display instantly on the graph.

Update: This makes sense, on second thought, as the sum of assets in report is more than all of the others combined.

from dagster.

@cohenj20 Do you see any errors in the developer console? If so can you share them here

from dagster.

@salazarm I do not see anything.

from dagster.

Would you be open to a zoom call so I can take a look? Keen on getting to the bottom of this.

from dagster.

I was messing around with which combinations of asset groups cause the issue, and I noticed that if the report asset group is selected, even if it's the only asset group selected, the UI hangs. As long as report is unselected, all assets display instantly on the graph.

I will pull on this thread

from dagster.

@salazarm If we can do it in an hour, sure. I need to step away for a bit.

from dagster.

@cohenj20 Yes that would work for me. Feel free to pop into https://meet.google.com/zje-xrev-vig?hs=122&authuser=0, I'll be waiting in there.

from dagster.

@cohenj20 I believe the issue you're facing is that the screen just looks blank? Correct? If so, I think there isn't actually a bug, it's just the default zooming took you to a spot where there where no assets. Try clicking on an asset in the sidebar to see if it zooms you to it.

from dagster.

For visibility, on the zoom call @salazarm and I confirmed there was the following error in the developer console:

Uncaught DOMException: Failed to execute 'importScripts' on 'WorkerGlobalScope': The script at 'http://127.0.0.1:3000/_next/static/chunks/framework-d6095a5336d3e425.js' failed to load.
    at __webpack_require__.f.i (http://127.0.0.1:3000/_next/static/chunks/358.85428c524e2522c9.js:1:2431)
    at http://127.0.0.1:3000/_next/static/chunks/358.85428c524e2522c9.js:1:1317
    at Array.reduce (<anonymous>)
    at __webpack_require__.e (http://127.0.0.1:3000/_next/static/chunks/358.85428c524e2522c9.js:1:1265)
    at Array.map (<anonymous>)
    at __webpack_require__.x (http://127.0.0.1:3000/_next/static/chunks/358.85428c524e2522c9.js:1:2853)
    at http://127.0.0.1:3000/_next/static/chunks/358.85428c524e2522c9.js:1:2935
    at http://127.0.0.1:3000/_next/static/chunks/358.85428c524e2522c9.js:1:2939

from dagster.

This will be fixed by #19046

from dagster.

#21129 *

from dagster.