Git Product home page Git Product logo

Comments (9)

gibsondan avatar gibsondan commented on July 3, 2024 1

Is putting this configuration on the runK8sConfig field here an option? https://github.com/dagster-io/dagster/blob/master/helm/dagster/values.yaml#L573-L591 - that would cause them to be applied to all runs by default

from dagster.

sverbruggen avatar sverbruggen commented on July 3, 2024

I noticed this very old PR which may be related: #9940

from dagster.

gibsondan avatar gibsondan commented on July 3, 2024

The configuration there looks correct to me. A couple of follow-up questions:

  • is it possible to post a debug file for a run with these tags? You can generate a debug file from this drop-down on the runs page
image
  • Can you post the output of "kubectl get pod POD_NAME_HERE -o yaml" where the pod name is one of your job pods for this job?

I don't think that PR is related - the tags you describe there should be working.

from dagster.

gibsondan avatar gibsondan commented on July 3, 2024

I tried creating a run with the tags that you specified and was able to see the configuration being applied in the launched run pod (excerpt from the kubectl get pod command I posted above):

  tolerations:
  - effect: NoSchedule
    key: agentpool
    operator: Equal
    value: node04
  - effect: NoSchedule
    key: agentpool
    operator: Equal
    value: node01
  - effect: NoSchedule
    key: agentpool
    operator: Equal
    value: node05
  - effect: NoSchedule
    key: agentpool
    operator: Equal
    value: node02
  - effect: NoSchedule
    key: agentpool
    operator: Equal
    value: node03
  - effect: NoExecute
    key: node.kubernetes.io/not-ready
    operator: Exists
    tolerationSeconds: 300
  - effect: NoExecute
    key: node.kubernetes.io/unreachable
    operator: Exists
    tolerationSeconds: 300

So the first thing that I would check is to verify that those tags are actually getting applied to the run. You can check that from the "View tags" button here:
image

You should see something like this in the dialog that opens if the tag was applied as expected:
image

from dagster.

ion-elgreco avatar ion-elgreco commented on July 3, 2024

Hi @gibsondan,

It occurs when triggering a backfill materialization from the asset pane instead of the job pane, see result below:

image

from dagster.

gibsondan avatar gibsondan commented on July 3, 2024

Got it - I think that explains what's happening here. Triggering a backfill materialization from the asset page isn't going to use that job.

from dagster.

ion-elgreco avatar ion-elgreco commented on July 3, 2024

@gibsondan In that case it's a bug, right? We have these default settings on the user deployment, however they are not picked up

from dagster.

ion-elgreco avatar ion-elgreco commented on July 3, 2024

See this issue for reference: #9924

from dagster.

ion-elgreco avatar ion-elgreco commented on July 3, 2024

Yup, we will try out tomorrow! Thanks @gibsondan ❤️

from dagster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.