interval.range should protect against infinite loops. about d3-time HOT 9 CLOSED

A reduction of this issue (requires switching to Brasilia Standard Time):

date = new Date("2017-10-08T03:00:00.000Z") // Date 2017-10-08T03:00:00.000Z
d3.timeWeek(date) // Date 2017-10-08T03:00:00.000Z
d3.timeWeek.offset(date, 1) // Date 2017-10-15T02:00:00.000Z
d3.timeWeek(d3.timeWeek.offset(date, 1)) // Date 2017-10-08T03:00:00.000Z

from d3-time.

Actually, it’s even worse in that d3.timeWeek is not idempotent:

date = new Date("2017-10-15T03:00:00.000Z") // Date 2017-10-15T03:00:00.000Z
d3.timeWeek(date) // Date 2017-10-15T02:00:00.000Z
d3.timeWeek(d3.timeWeek(date)) // Date 2017-10-08T03:00:00.000Z

from d3-time.

In vanilla JavaScript (Firefox):

date = new Date("2017-10-15T03:00:00.000Z") // Date 2017-10-15T03:00:00.000Z
date.setHours(0, 0, 0, 0) // Date 2017-10-15T02:00:00.000Z
date.setHours(0, 0, 0, 0) // Date 2017-10-14T03:00:00.000Z

Whereas in Chrome:

date = new Date("2017-10-15T03:00:00.000Z") // Date 2017-10-15T03:00:00.000Z
date.setHours(0, 0, 0, 0) // Date 2017-10-15T03:00:00.000Z
date.setHours(0, 0, 0, 0) // Date 2017-10-15T03:00:00.000Z

So in other words, calling date.setHours in Firefox is changing the date from the 15th to the 14th.

from d3-time.

(d3.timeDay is also not idempotent in Firefox, for the same reasons.)

from d3-time.

I’m not sure it’s feasible to return the correct result in Firefox; in general, D3 is not a compatibility layer, so I rarely try to workaround a bug in date.setHours (and I think this counts as a bug… although perhaps I am misreading the spec). That said, if there’s a reasonably simple workaround, I’d be amenable to using it—I just can’t think of one immediately.

I’d also like to guarantee that interval.range can’t go into an infinite loop, but I think that would still mean that Firefox would have incorrect results. I’ll change this issue title accordingly.

from d3-time.

Any plans to make a new release soon with this patch?

from d3-time.

Thanks for the reminder. Will try to do this soon…

from d3-time.

Is there any update on this? We are blocked on releasing a project as this is still a problem with Firefox 57. Thank you!

from d3-time.

Will try today. Thanks for the reminder.

from d3-time.