Visualizing data based on Hijri date series about d3-time HOT 2 CLOSED

This library doesn’t implement a calendaring system per se; it relies on JavaScript’s built-in Date class, which implements the Gregorian calendar. In theory, it would be possible to extend this library to support other calendaring systems, but I don’t have a sense of how practical that would be. I see two challenges:

1. This library calls new Date internally (see interval.js), so if you want to substitute a different Date class (such as hijri-date), you’ll need to modify the code to allow the Date constructor to be overridable. The Date substitute will also need to implement date.setTime.

2. The built-in intervals may or may not be applicable in the non-Gregorian calendar system. Depending on which of these built-in intervals you want to reuse, the Date substitute will need to implement other methods. For example, the day interval requires date.setHours, date.setDate, date.getDate and date.getTimezoneOffset.

I do not personally plan on implementing the Hijri calendar in JavaScript, so I am going to close this issue. But, if you wish to submit a pull request to address the first issue and allow the Date constructor to be overridable, I would be happy to review it, especially if you are willing to include a demonstration showing how to use it with other calendar systems. Thank you!

from d3-time.

Hello @mbostock ,

I did some investigation in Hijri Date , I found some missing implementation need to be added as setTime, setHours, .. we request that from owner to be able to use it here.
Can you advise the best way to use external library like Hijri Date, with D3-Time. Especially if this library contain "require" function between files. If there an example you can share this will be great.

from d3-time.