czyzby / wesnoth-wml-linter Goto Github PK

Add action parameters that specify the verified file path and a custom Wesnoth branch or tag to verify against.

Add support for wmllint spellchecking via hunspell.

This message looks rather concerning:

Cloning Wesnoth 1.16.10.
Cloning into '/wesnoth'...
fatal: specify directories rather than patterns.  If your directory really has any of '*?[]\' in it, pass --skip-checks
Wesnoth repository is ready.

It doesn't actually cause any failures, though, so I guess it's more just of an annoyance than anything... still, it might be worth trying to pass the --skip-checks flag to whatever printed that message anyways, though?

Renaming the default branch of the repository to latest will make it intuitive to pull the latest version of the action within GitHub workflows.

Implement GitHub action that verifies WML files.

In wesnoth/wesnoth@c1a074e, @Elvish-Hunter added a check to wmllint validate rank= values, as I had requested in wesnoth/wesnoth#7224. This check generally works well enough when I'm running wmllint locally, however, when run as part of this action, it will print a warning like this:

 "_main.cfg", line 10: rank for mainline campaigns should be a multiple of 5 between 0 and 299 (included)

However, the add-on in question that I'm checking isn't supposed to be a mainline campaign, but rather, it's an add-on. See:
https://github.com/cooljeanius/A_Little_Adventure/actions/runs/7363399849/job/20042827417

It'd be useful to checkout at least data/core from the wesnoth repo and add that to the wmllint invocation so it knows about the core macros etc. That way the action user doesn't have to do that. Could perhaps be optional if it's costly.