cytechmobile / reminderbot Goto Github PK

When requesting the bot to show all reminders, the reported time is not in the correct time zone

when you send a reminder to a room eg remind #general to come to meeting in 10:00 the message doesn't come with a card that needs to be fixed so you can cancel the reminder or use it again in 10 minutes

when submitting a reminder with a command similar to:
@reminder remind me to do something at some time

The received reminder is:
to do something

It would look much better if the to was skipped.

replace thorntail with Quarkus.io

Add command to report running bot version (ideally only on personal chats? to not pollute rooms with such details)?
something like
version
My version is: x.y.z

The bot keywords should be verbs, better reflecting the action and making the language more intuitive:

• reminder -> remind: This would allow language: @reminderbot remind me ...
  Make similar changes to all other used keywords

Currently the code base suffers from readability/maintainability. We need to improve on that by making certain changes according to identified patterns, such as:

• @Transactional should only be used where it is (proven to be) essential, not abused.
• Bot message building should be converged and re-used, rather than created as a string concatenation where needed
• Json handling should be converged, rather than performed on-demand with either (un)marshalling, or as string splitting, etc

JMockit is extremely unstable and breaks with almost every minor update (either of the tool itself, or any of the underlying testing framework).
Most suggested tool to use would be mockito.

when listing reminders the timezone is UTC+00 this should fix to timezone the reminder got saved and not always in 00 so you can actually see when the reminder will ping you if you set it to other days like remind me hello on Thursday

In current size of 'what' in the table reminder is 50 chars - there is a check for that also in checkReminderFormat().

Please guide how we can setup this bot on a server and which database we have to install to use it.
It would be great help if we know proper command for maven

The help message should be changed to reflect what's on the README, possibly also including a link to it.

Is your feature request related to a problem? Please describe.
It is too difficult to read the help instruction although the content is good

Describe the solution you'd like
It would be nice to show the help somewhat more readable. I would propose to be wider and use formatting like bold and italics etc

Describe alternatives you've considered
Maybe we can think of a step by step help using sub-commands like reminder help list

Automatically create git tag based on project version when building in CI for master branch

• such as https://github.com/ocpsoft/prettytime

• Docs/examples: https://www.ocpsoft.org/prettytime/nlp/

When asking the bot to change the user/default time zone, the time zone is reported as a city (e.g. Athens).
Change that so that it also supports full time zone (e.g. Europe/Athens), as well as make it case-insensitive (e.g. allow athens)

AS a reminder bot user

I WANT to set repetitive reminders with a optionally settable interval till asked to be called off (at best cancel with link click, not with keyboard)

SO THAT i can set reminder for something that needs to be done but not always at the time i noticed and can be postponed for later

alternatively on each reminder offer to repeat (by clicking) a few options like

remind me again in <link>10'</link> or <link>tomorrow</link> or <link>next week</link>

As a user, I want to be able to set bot's configuration values via chat, rather than having to manually set them up through a configuration file, environment variables or the database (e.g. the bot's base url).

Currently, CI verifies a build after building a docker image and running tests against it, but does not push it to Docker Hub. Instead, Docker Hub gets notified for a push to master (or a tag) and builds the image from sources (using the Dockerfile in the repo).
Ideally, this should change so that the image that was built and tested should get pushed to Docker Hub.

right now we miss a test that makes sure when we delete reminder it all goes well. we have no idea when deleting a reminder will break and we need a test for it

Is your feature request related to a problem? Please describe.

My problem is I can't use slack that has the wonderful message to remind me about a particular message after a custom period of time.

Describe the solution you'd like

Ditch Google Chat and use Slack ( or, better yet, another open source solution that provides this functionality - but I don't know of one).

Instead, I'd wish I could use this chat bot right here!

Describe alternatives you've considered

• Ignoring colleagues who choose to use google chat.
• Petitioning to the CEO
• Quitting the company
• Convincing google it's about time they retired google chat.

Additional context

( comments above are meant to be taken with a grain of salt : ) )

AS a reminder bot user

I WANT to set recurring reminders with a settable interval (e.g. every hour/day/week/month) and some kind of way to cancel it (e.g. delete it)

Add checkstyle in the project, so as to have consistent formatting

When setting a reminder with:
@reminder remind me to test you in 1'
the bot responds with an error due to exception:

Error from message:@reminder remind me to test you in 1': java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
boom!