cyansalt / vite-plugin-legacy-swc Goto Github PK
View Code? Open in Web Editor NEWProvides legacy browsers support for the production build with SWC
License: ISC License
vite-plugin-legacy-swc's People
Contributors
Stargazers
Watchers
Forkers
modyqywvite-plugin-legacy-swc's Issues
Could the minify option be acceptable?
Hello!
Looking at the plugin implementation, it is set to false, but @vitejs/plugin-legacy binds the value according to the build.minify option. Is there a reason that option is false?
vite-plugin-legacy-swc/src/index.ts
Line 703 in 6a0fc35
Types not exported, causing issues with NodeNext
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch [email protected] for the project I'm working on.
It seems like the "types" export is missing, causing issues with typescript when using moduleResolution: "NodeNext"
Here is the diff that solved my problem:
diff --git a/node_modules/vite-plugin-legacy-swc/package.json b/node_modules/vite-plugin-legacy-swc/package.json
index 62cbde3..f35c247 100644
--- a/node_modules/vite-plugin-legacy-swc/package.json
+++ b/node_modules/vite-plugin-legacy-swc/package.json
@@ -8,6 +8,7 @@
"types": "./dist/index.d.ts",
"exports": {
".": {
+ "types": "./dist/index.d.ts",
"import": "./dist/index.mjs",
"require": "./dist/index.cjs"
}This issue body was partially generated by patch-package.
esm/commonjs import issue
Trying to import this legacy plugin like so
import { defineConfig } from "vite";
import react from "@vitejs/plugin-react-swc";
import legacy from "vite-plugin-legacy-swc";
// https://vitejs.dev/config/
export default defineConfig({
plugins: [react(), legacy()],
});causes the following error:
~/src/vite-project master ✔ ◒
▶ yarn build
yarn run v1.22.19
$ tsc && vite build
failed to load config from /home/bjorn/src/vite-project/vite.config.ts
error during build:
TypeError: legacy is not a function
at file:///home/bjorn/src/vite-project/vite.config.ts.timestamp-1676562433105.mjs:6:22
at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
at async Promise.all (index 0)
at async ESMLoader.import (node:internal/modules/esm/loader:530:24)
at async loadConfigFromBundledFile (file:///home/bjorn/src/vite-project/node_modules/vite/dist/node/chunks/dep-3007b26d.js:62302:21)
at async loadConfigFromFile (file:///home/bjorn/src/vite-project/node_modules/vite/dist/node/chunks/dep-3007b26d.js:62187:28)
at async resolveConfig (file:///home/bjorn/src/vite-project/node_modules/vite/dist/node/chunks/dep-3007b26d.js:61808:28)
at async build (file:///home/bjorn/src/vite-project/node_modules/vite/dist/node/chunks/dep-3007b26d.js:44492:20)
at async CAC.<anonymous> (file:///home/bjorn/src/vite-project/node_modules/vite/dist/node/cli.js:813:9)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.In order to make it work, you have to do this
import legacyPkg from 'vite-plugin-legacy-swc'
// @ts-expect-error the package type definition is wrong
const legacy = legacyPkg.default as typeof legacyPkgSteps to recreate:
$ yarn create vite
$ # Select React, Typescript + swc
$ yarn add -D vite-plugin-legacy-swc
$ # Edit vite.config.ts to match the first one in this issue
$ yarn buildNode version: v18.12.0
Align @vitejs/[email protected]
@vitejs/plugin-legacy just launched v5.3, including 3 feat.
Glad to submit a PR. But let's start aligning until vitejs/vite#15788 is solved.
Packaging will generate two sets of codes
Packaging will generate two sets of codes, one is for modern browsers, and the other is code that is compatible with lower versions. How to set up to generate only one set of code that is compatible with lower versions?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.