Git Product home page Git Product logo

Comments (6)

sarah-cul avatar sarah-cul commented on August 12, 2024
image

from uls.

sarah-cul avatar sarah-cul commented on August 12, 2024

@mhk33 turns out the font types are set in the culu theme, when I made the change I noticed the new fonts are smaller so I had to make a few minor adjustments to the padding for the button and increased the size of the "Search" label. Do you think this is ok, or should i increase the font size slightly everywhere? Even the hero title library name is smaller now.

from uls.

mhk33 avatar mhk33 commented on August 12, 2024

@sarah-cul Yes, Freight is a smaller font and I've had to adjust the sizing on the various sites where I've used it. You could maybe change the overall font size in the body tag and see if that works nicely. For example, instead of font-size: 1rem, change it to 1.1rem (or use percentage, em, whatever makes sense).

I opted not to do it this way on the main site, in order to keep the sizes "true." Instead I changed elements manually throughout the scss partials. This was more work, but I was reviewing everything closely anyway so didn't really mind.

from uls.

mhk33 avatar mhk33 commented on August 12, 2024

@sarah-cul I realized I'm not sure I answered your question exactly... I also think it looks OK in the screenshots, even the site title. Mostly I have found the need to bump up the body font (<p> and such), but it looks OK to me here. If you get it up on a test site I'm happy to take a look there, too.

from uls.

sarah-cul avatar sarah-cul commented on August 12, 2024

@mhk33 thanks for the feedback.. I will let you know about a test site that would be great to have another person test it out. I'm working on playing with font sizes now and its looking similar to the previous proportions. I want to roll this out for the next upstream since its a culu theme change.

from uls.

sarah-cul avatar sarah-cul commented on August 12, 2024

This work is completed in v1.7.6 of the culu theme so it will roll out in the next upstream

from uls.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.