Git Product home page Git Product logo

Comments (5)

ctrlmaniac avatar ctrlmaniac commented on May 25, 2024

Are you sure you've upgraded to the latest version? I know bower has some strange problems upgrading to the latest version if it is a major release and sometimes it happens to minors too.
I am asking because I had the same problem with Bower and Grunt that drove me crazy an entire day, until I understood that Bower had some conflicts and couldn't choose between v2.0.4 and v2.1.4. I had to reinstall the package.

I have actually fixed this bug with the f3aaddf commit. This commit was included in v2.0.4 release, and in its changelog I am mentioning the same behavior that your package has!

By now the latest release is the v2.1.4 which fix #27 and officially adds jQuery v2.x.x and v3.x.x. I guess you should have updated to this version!

1 - Can you please post me the entire header shipped with the version you are using?
The latest header is:

/*! simpler-sidebar v2.1.4 (https://github.com/simple-sidebar/simpler-sidebar#readme)
** Copyright (c) 2015 - 2016 Davide Di Criscito
** Dual licensed under MIT and GPL-2.0
*/

2 - Please, copy and paste line 82 and line 251 of the dist/jquery.simpler-sidebar.js file delivered with the bower package you installed. If you installed the latest version, those two lines should be:

82 | quitter = ( !cfg.selectors.quitter ) ? "a" : cfg.selectors.quitter,
...
251| $sidebar.on( "click", quitter, animateClose );

3 - Are you using any custom event? I guess you are using the events.callbacks.animation.freezePage but that worked since ever and it hasn't changed.

4 - Can you please test it with another jQuery version?

Unfortunately I can't test your website because I don't have access to its code, plus I don't use Bootstrap so I can't reproduce this behavior!
I don't think it's Bootstrap conflicting with the simpler-sidebar plugin, but If you explain me how to replicate the template you are using (or even provide me a simple, basic html page) I will be glad to test it!

from sidebar.

ericandrewscott avatar ericandrewscott commented on May 25, 2024

@dcdeiv you're right. I had my bower file set to latest major revision ("simpler-sidebar": "^2.1.4"), but it was stuck on 2.0.2. Bower update wasn't working. That's annoying. I removed the ref, rebuilt, added it back, rebuilt, and now it works. Thanks!

from sidebar.

ctrlmaniac avatar ctrlmaniac commented on May 25, 2024

You're welcome! 👍

from sidebar.

ericandrewscott avatar ericandrewscott commented on May 25, 2024

@dcdeiv I've been meaning to tell you that the changes you made in version 2 are pretty spectacular. Simpler-sidebar is pretty lightweight and slick!

from sidebar.

ctrlmaniac avatar ctrlmaniac commented on May 25, 2024

Thank you very much! This is the very first feedback I receive! I really appreciate that you like this plugin!

from sidebar.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.