Git Product home page Git Product logo

Comments (25)

ctrlmaniac avatar ctrlmaniac commented on May 24, 2024

Do you mean this option?

Have you checked out the demo pages? Especially this one?

Have you properly migrated to the latest version?

Can you post your snippet code?

from sidebar.

ctrlmaniac avatar ctrlmaniac commented on May 24, 2024
events: {
        callbacks: {
            animation: {
                freezePage: false
            }
        }
    }

from sidebar.

daslicht avatar daslicht commented on May 24, 2024

Hi, thank you for you reply !

here is the sidebar in action :

http://goo.gl/k6XJsM

I have just tried to add that freesPage option but it do not seam to have an effect.

  var closingLinks = '.close-sidebar';
   $('#sidebar').show();
    var $sidebar = $('#sidebar').simplerSidebar({
        opener: '.navbar-toggler',
        animation: {
            duration: 500,
            easing: 'easeOutQuint'
        },
        sidebar: {
            align: 'left',
            width: 250,
            closingLinks: closingLinks,
        },
        mask: {
            display: true
        },
        events: {
        callbacks: {
            animation: {
                freezePage: false
            }
        }
    }

    });

I have installed it using bower:

 "simpler-sidebar": "^1.4.11",

from sidebar.

daslicht avatar daslicht commented on May 24, 2024

Just tried upgrading to the latest version but with the same code which worked before I get :

Uncaught TypeError: Cannot read property 'trigger' of undefined

from sidebar.

ctrlmaniac avatar ctrlmaniac commented on May 24, 2024

Do you use Bower, npm or did you just download the code from Github?

  1. YOU HAVE TO UPDATE YOUR LOCAL PACKAGE TO V2.0.2
  2. Have you followed the getting started guidelines?
  3. Your code is old and full of mistakes!!!
    • Please update the package and your custom options to v2.0.2!!! THAT MEANS THAT YOU HAVE TO UPDATE THE OPTIONS TOO!!!!!!!!!
var $sidebar = $( "#sidebar" );

$sidebar
    .show()
    .simplerSidebar( {
        align: "left", // the new sidear.align
        selectors: {
            trigger: ".navbar-toggler", // the new opener
            quitter: ".close-sidebar" // the new closingLinks
        },
        animation: {

            //duration: 500, // that is default, you can remove this line
            easing: "easeOutQuint"
        },
        sidebar: {
            width: 250
        },
        /*
        ** This is default, you can remove this option!
        mask: {
            display: true
        },
        */
        events: {
            callbacks: {
                animation: {
                    freezePage: false
                }
            }
        }
    } );

from sidebar.

ctrlmaniac avatar ctrlmaniac commented on May 24, 2024

Duplicate of #16

from sidebar.

ctrlmaniac avatar ctrlmaniac commented on May 24, 2024

If you need some help, please ask.
But be sure to read all documentation before asking!

from sidebar.

daslicht avatar daslicht commented on May 24, 2024

Please, help up upgrade the plugin!
pardon ?

YOU HAVE TO UPDATE YOUR LOCAL PACKAGE TO V2.0.2
yes I tried via bower and the zip

Have you followed the getting started guidelines?
yes

Your code is old and full of mistakes!!!
Please update the package and your custom options to v2.0.2!!! THAT MEANS THAT YOU HAVE TO UPDATE THE OPTIONS TOO!!!!!!!!!

keep cool

Have a nice day!

from sidebar.

ctrlmaniac avatar ctrlmaniac commented on May 24, 2024

What I am trying to say is that you ugraded the package but not your options.

When packages have to be upgraded from v1.x.x to v2.x.x this means that the new version is a major release, thus the two options and packages won't live nice together.

Everything is changed. That is why the package isn't working, you are using the old options api. That means that you have to upgrade them.

I also rewrote your options upgrading them to the new features and options in v2.0.2 before:

var $sidebar = $( "#sidebar" );

$sidebar
    .show()
    .simplerSidebar( {
        align: "left", // the new sidear.align
        selectors: {
            trigger: ".navbar-toggler", // the new opener
            quitter: ".close-sidebar" // the new closingLinks
        },
        animation: {

            //duration: 500, // that is default, you can remove this line
            easing: "easeOutQuint"
        },
        sidebar: {
            width: 250
        },
        /*
        ** This is default, you can remove this option!
        mask: {
            display: true
        },
        */
        events: {
            callbacks: {
                animation: {
                    freezePage: false
                }
            }
        }
    } );

I have provided a brand new getting started guide along with the v2.0.2, a brand new doc folder with all explanations of the new options and a changelog too with a migrate section that helps to bring old features to the new ones. And you are just ignoring them!

I also gave you the links in the previous posts and you didn't read them.

I am angry because I am telling you this several times, but you just keep ignoring what I am saying.

from sidebar.

daslicht avatar daslicht commented on May 24, 2024

Anything is fine :)
you know... , these messages are not in real time.
I have immediately inspected you links and upgraded to version 2.0.2 as well as the code you kindly provided for me. But it didn't worked, yet.

I cant test it further right now, since out webserver is doing some updates at the moment and not responding :/

If you like I keep you posted.

Thank you very much for your time !

from sidebar.

ctrlmaniac avatar ctrlmaniac commented on May 24, 2024

Yes, please! Keep me updated! But please, do not edit previous post, because I can't be notified of that changes!

from sidebar.

daslicht avatar daslicht commented on May 24, 2024

Yeah editing posts seam to be less good and lead to misunderstandings :)

from sidebar.

ctrlmaniac avatar ctrlmaniac commented on May 24, 2024

As soon as your server will be online I will inspect the source code. Maybe there are some issues with other packages or plugins. In the mean time, check all new demo pages!

from sidebar.

daslicht avatar daslicht commented on May 24, 2024

The Server is back.
Looks like the sidebar gets initialized but the trigger have no effect.
Here is the code I am using :
http://goo.gl/GEAoEf

from sidebar.

ctrlmaniac avatar ctrlmaniac commented on May 24, 2024

I need to see the source code of the entire HTML page! Right now I don't have a PC to inspect it, I will answer you as soon as I get to a PC.

By now try to remove the show method and all comments!
Also check if the selectors are right!

from sidebar.

daslicht avatar daslicht commented on May 24, 2024

I need to see the source code of the sentire HTML page!
Here ya go :

<button class="navbar-toggler hidden-md-up" type="button">
    &#9776;
</button>

<div id="sidebar" class=''>
    <div id="sidebar-wrapper" class="sidebar-wrapper bg-primary z-depth-1">
        <a href="/" title="home" class="sidebar-brand p-a-1">
            <img class="img-fluid" src="{{'/assets/images/logo/image.jpg' | theme}}" alt="JumpLink Logo">
        </a>

        <div class="list-group">
            <a href="{% if this.page.id != 'home' %}{{'home'|page}}{% endif %}/shipping" class="close-sidebar list-group-item">Shipping</a></li>
            <a href="{% if this.page.id != 'home' %}{{'home'|page}}{% endif %}liner-services" class="close-sidebar list-group-item">Liner Services</a></li>
            <a href="{% if this.page.id != 'home' %}{{'home'|page}}{% endif %}port-agency" class="close-sidebar list-group-item">Port Agency</a>
            <a href="{% if this.page.id != 'home' %}{{'home'|page}}{% endif %}offshore" class="close-sidebar list-group-item">Offshore</a>
            <a href="{% if this.page.id != 'home' %}{{'home'|page}}{% endif %}contact" class="close-sidebar list-group-item">Contact</a>          
        </div>
    </div>
</div>
var $sidebar = $( "#sidebar" );

$sidebar
    .show()
    .simplerSidebar( {
        align: "left", // the new sidear.align
        selectors: {
            trigger: ".navbar-toggler", // the new opener
            quitter: ".close-sidebar" // the new closingLinks
        },
        animation: {

            //duration: 500, // that is default, you can remove this line
            easing: "easeOutQuint"
        },
        sidebar: {
            width: 250
        },
        /*
        ** This is default, you can remove this option!
        mask: {
            display: true
        },
        */
        events: {
            callbacks: {
                animation: {
                    freezePage: false
                }
            }
        }
    } );

By now try to remove the show method and all comments!
That was the first i tried :)

Also check if the selectors are right!
of course 8)

from sidebar.

ctrlmaniac avatar ctrlmaniac commented on May 24, 2024

Are the changes online at the previous link you provided to me? I managed to inspect the source code with my mobile at this link. I can't see at the bottom of the page the jquery and jquery-ui CDN s nor the sidebar options code!

from sidebar.

daslicht avatar daslicht commented on May 24, 2024

The sidebar is initialized here:
http://goo.gl/GEAoEf

See the console, console.log('navigation.js called');
that verifies that the file is running and jquery present.
Besides that version 1.4 was working except the freeze option

from sidebar.

daslicht avatar daslicht commented on May 24, 2024

please do not post the link public which contains client names .

from sidebar.

ctrlmaniac avatar ctrlmaniac commented on May 24, 2024

OK, I'll answer you later when I get to my PC. I removed the links!

from sidebar.

daslicht avatar daslicht commented on May 24, 2024

the following assets are combined :

<script src="{{ [
    'assets/vendor/jquery/dist/jquery.min.js',
    'assets/vendor/jquery-ui/jquery-ui.min.js',
    'assets/vendor/tether/dist/js/tether.js',
    'assets/vendor/bootstrap/dist/js/bootstrap.js',
    'assets/vendor/slick-carousel/slick/slick.js',
    'assets/vendor/masonry/dist/masonry.pkgd.min.js',
    'assets/vendor/simpler-sidebar/dist/jquery.simpler-sidebar.min.js'
]|theme }}"></script>

output:
goo.gl/zKhb01

yeah take you time !

from sidebar.

ctrlmaniac avatar ctrlmaniac commented on May 24, 2024

OK, so everything is included but I still can't find out why the sidebar
isn't responding. Demos works fine, so I fear there are incompatibility
issues with other plugins!

from sidebar.

daslicht avatar daslicht commented on May 24, 2024

I try to narrow it down

from sidebar.

ctrlmaniac avatar ctrlmaniac commented on May 24, 2024

I finally had time to inspect your code carefully and in the file where you combine the vendor libs, the simpler-sidebar plugin is not updated.

As you can see, this is the header I've found at the bottom of the page:

/*! simpler-sidebar v1.4.11 (https://github.com/dcdeiv/simpler-sidebar#readme)
** Copyright (c) 2015 - 2016 Davide Di Criscito
** Dual licensed under MIT and GPL-2.0
*/

The current header is:

/*! simpler-sidebar v2.0.2 (https://github.com/simple-sidebar/simpler-sidebar#readme)
** Copyright (c) 2015 - 2016 Davide Di Criscito
** Dual licensed under MIT and GPL-2.0
*/

The simpler-sidebar plugin has been moved from https://github.com/dcdeiv/simpler-sidebar to https://github.com/simple-sidebar/simpler-sidebar. If you are using Bower there should not be any problems because I manually changed the bower repository to link to the new git repository.

However, if you are using a task runner such as Grunt or Gulp, you should run the combine command again to fetch the latest updates!

from sidebar.

daslicht avatar daslicht commented on May 24, 2024

Application Cache cleared and anything is working !

Thank you very much !

from sidebar.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.