csparker247 / ffdropenc Goto Github PK

All presets incorrectly call getLength()

The project fails to build on Debian when using either the apt Qt5 libs or a manually installed version:

$ make
Scanning dependencies of target ffde_core
[  5%] Building CXX object libdropenc/CMakeFiles/ffde_core.dir/src/Filesystem.cpp.o
[ 10%] Building CXX object libdropenc/CMakeFiles/ffde_core.dir/src/Preset.cpp.o
[ 15%] Building CXX object libdropenc/CMakeFiles/ffde_core.dir/src/QueueItem.cpp.o
[ 20%] Building CXX object libdropenc/CMakeFiles/ffde_core.dir/src/TimeTools.cpp.o
[ 25%] Linking CXX static library ../lib/libffde_core.a
[ 25%] Built target ffde_core
Scanning dependencies of target ffdropenc_autogen
[ 30%] Automatic MOC and UIC for target ffdropenc

AutoMoc subprocess error
------------------------
The moc process failed to compile
  "SRC:/apps/include/MainApplication.hpp"
into
  "SRC:/build/apps/ffdropenc_autogen/6YEA5652QU/moc_MainApplication.cpp"

Command
-------
/usr/bin/moc -DJSON_USE_IMPLICIT_CONVERSIONS=1 -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -I/ffdropenc/apps/include -I/ffdropenc/build/apps -I/ffdropenc/libdropenc/include -I/ffdropenc/build/_deps/json-src/single_include -I/usr/include/QtCore -I/usr/mkspecs/linux-g++ -I/usr/include/QtGui -I/usr/include/QtWidgets -I/usr/include -I/usr/include/c++/8 -I/usr/include/x86_64-linux-gnu/c++/8 -I/usr/include/c++/8/backward -I/usr/lib/gcc/x86_64-linux-gnu/8/include -I/usr/local/include -I/usr/lib/gcc/x86_64-linux-gnu/8/include-fixed -I/usr/include/x86_64-linux-gnu --include /ffdropenc/build/apps/ffdropenc_autogen/moc_predefs.h -p ./ -o /ffdropenc/build/apps/ffdropenc_autogen/6YEA5652QU/moc_MainApplication.cpp /ffdropenc/apps/include/MainApplication.hpp

Output
------
usr/include/c++/8/bits/fs_fwd.:39: Parse error at "std"


AutoMoc subprocess error
------------------------
The moc process failed to compile
  "SRC:/apps/include/EncodingQueue.hpp"
into
  "SRC:/build/apps/ffdropenc_autogen/6YEA5652QU/moc_EncodingQueue.cpp"

Command
-------
/usr/bin/moc -DJSON_USE_IMPLICIT_CONVERSIONS=1 -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -I/ffdropenc/apps/include -I/ffdropenc/build/apps -I/ffdropenc/libdropenc/include -I/ffdropenc/build/_deps/json-src/single_include -I/usr/include/QtCore -I/usr/mkspecs/linux-g++ -I/usr/include/QtGui -I/usr/include/QtWidgets -I/usr/include -I/usr/include/c++/8 -I/usr/include/x86_64-linux-gnu/c++/8 -I/usr/include/c++/8/backward -I/usr/lib/gcc/x86_64-linux-gnu/8/include -I/usr/local/include -I/usr/lib/gcc/x86_64-linux-gnu/8/include-fixed -I/usr/include/x86_64-linux-gnu --include /ffdropenc/build/apps/ffdropenc_autogen/moc_predefs.h -p ./ -o /ffdropenc/build/apps/ffdropenc_autogen/6YEA5652QU/moc_EncodingQueue.cpp /ffdropenc/apps/include/EncodingQueue.hpp

Output
------
usr/include/c++/8/bits/fs_fwd.:39: Parse error at "std"

make[2]: *** [apps/CMakeFiles/ffdropenc_autogen.dir/build.make:58: apps/CMakeFiles/ffdropenc_autogen] Error 1
make[1]: *** [CMakeFiles/Makefile2:973: apps/CMakeFiles/ffdropenc_autogen.dir/all] Error 2
make: *** [Makefile:152: all] Error 2

Especially on image sequences with large frame sizes. Will be compounded when we call getLength() twice: once to calculate total work and once to when we calculate right before encode.

Find a better way to check whether Xcode compiler is installed.

Presets need to be updated to use stream selectors for maxrate and bufsize settings. Not selecting a video stream when applying these can cause unexpected errors in output.

E.g. mediainfo reports that an audio stream has a maxrate that matches the intended maxrate of the video stream.

They probably don't take PAR into account.

Currently -preset and -tune can only be added to the miscellaneous "flags" array of a preset. May not be necessary, but might be nice.

Progress tracker doesn't take pullup into account. This leads to slight progress inaccuracy when doing inverse telecine.

jpeg/JPEG

Width not divisble by 2 for all presets.

Title. Not being divisible by 2 causes transcoder to fail.

Current implementation is pretty hacky. Need a better way to deal with incongruities in metadata.

Need a standard way to deal with libfdk_aac > aac preset conversion.

The audio options in the ProRes preset reject files with no audio tracks.

Implement some sort of automation to test all functionality.

To-do:

• Ask for input/output frame rate for sequences
• Ask for output directory
• Report which file is being processed
• Get queue working
• Parse ffmpeg output for progress tracking
• Analyze input files
• Combine preset args and input file information
• Add support for alternate encoder process (ffmpeg, x264, etc.)
• Fix weird QApplication and QProcess errors
• Fix Chromecast preset (not sure what's broken)
• Fix ProRes preset (when no audio) (#14)
• Cancel button
• Collapse details
• Report errors to details
• Drag to app icon
• App packaging and SDK builds (non-free)
• H.264 scaling problem (#23)
• Update documentation
• Image sequences start from dragged image, not sequence start
• Port mp3 preset (moved to #32)
• LICENSE and such

ffprobe sometimes returns Programs.program.streams.stream.0.nb_frames for -show_entries stream=nb_frames, thus breaking progress tracking. I haven't figured out why. It's super annoying though.

Perhaps a good reason to use analyze()?

Scaling logic can be wacky for anamorphic inputs. For instance, if you give a 1280x720 (PAR 1:1) output preset a DVCPRO HD 1080 file (1280x1080, PAR 32:27) it will output a 1920x1080 (PAR 1:1) file.

Qt5 supports dropping files onto the app icon in order to open them. However, these drops are given by the event system as a series of individual File Opens rather than as a list of File Opens. This prevents us from properly adding a group of files to the Queue with the same encode settings. We need to explore alternatives to this problem.

File drops on the app icon will be disabled until this is solved.

Directories of image sequences seem to be creating duplicate queue entries resulting in multiple partial encodes.

When deploying against Homebrew's Qt6, macdeployqt only copies the frameworks into the app bundle and not the plugins. This causes the app to crash on launch. If just building the application without running the deploy utility, everything launches correctly indicating that the app is correctly linked against the dynamic libraries.

Probably should test against the official Qt6 installed frameworks to see what happens there.

For instance, giving Generic SD a 1440x1080 (4:3 DAR, 1:1 PAR) video creates an 853x640 output.

Should we prioritize image height?

Need to test:
4k -> 1080p

Create auto-build system to fix binary redistribution.

From @hayashidalex:

ls *.png | sort --version-sort | xargs cat | ffmpeg -framerate 5 -f image2pipe -i - file.mp4

Certain frame sizes (e.g. 2048x1080) result in a non-compliant output frame size after scaling (1920x1013), causing encoding to fail. This whole system should be rethought as Encore CS6 doesn't seem to like frame sizes that aren't the standards (1920x1080, 1280x720).

The mp3 preset wasn't ported in the transition to C++. The bash version is still in the presets directory.

Add a Windows release build.

Add a Linux release build.

Currently the input file is accessed in presets by ${filelist[$index]}. There should probably be a cleaner alias that differentiates this from $INFILE.

For sure fails with ProRes inputs. Works with H.264 inputs.

The app package on macOS should really be code signed. Need to investigate how to make this happen with CMake and Qt5.