csdms-contrib / cem Goto Github PK

@plimber, @haileyajohnson:

InitNormal writes past the end of the TypeOfRock and topography arrays when setting fast and slow weathering portions.

for (x = 0; x < X_MAX; x++) {
  for (n = 0; n <= 2 * NUMBER_CHUNK; n++) {
    for (y = n * CHUNK_LENGTH; y < ((n + 2) * CHUNK_LENGTH); y++) {
      if (n % 3 == 0 && (!blocks || x > InitialRock - 3)) { // if even
        TypeOfRock[x][y] = 's';
        topography[x][y] = kCliffHeightSlow;
      }
      else { // if odd
        TypeOfRock[x][y] = 'f';
        topography[x][y] = kCliffHeightFast;
      }
    }
}

Depending on the values for NUMBER_CHUNK and CHUNK_LENGTH, y will eventually be larger than 2 * Y_MAX, which is the number of columns for the arrays in question.

I propose that the length of each chunk be calculated based on Y_MAX and the number of chunks (NUMBER_CHUNK). I suppose the opposite would also work: calculate the number of chunks based on the number of columns and the chunk length. We will also have to do something with partial chunks if the number of columns isn't a multiple of the length of chunks.

The other thing is that the code within the innermost loop doesn't appear to do what the comments suggest (n % 3 doesn't test for even/odd) and overwrites data right after it's been initialized (perhaps n++ should be n+=2?).

There don't seem to be obvious instructions for

• running CEM with non-default inputs
• specifying wave data or other input parameters
• editing pertinent parts of the code