Runtime error: Index out of bounds (IndexError) about crystal-mysql HOT 3 CLOSED

changing
{13, auth_plugin_data_length - 8}.max - 1]
to
auth_plugin_data_length < 22 ? 12 : (auth_plugin_data_length - 9)
should be sign-safe.

or changing auth_plugin_data_length to auth_plugin_data_length.to_i16 (or to_i32) should be enough since auth_plugin_data_length is UInt8.

There is no further reason than trying to implement the internals of mysql protocol. And, as you see there are chances to miss some details :-(. Thanks for jumping in crystal-mysql!

If the latest proposal work feel free to submit a PR. :-)

from crystal-mysql.

I've been having fun exploring Crystal more and more, and it's awesome to see all the work you have put in! And I'm all for implementing internal protocols. No better way to learn what's happening under the hood. See PR #4 hopefully working around this issue.

from crystal-mysql.

PR merged at 6db306e.

I had fun with mysql internals too.

There are plenty of things pending to be implemented. And we try to move forward crystal-db family all together, but feel free to collaborate with the missing parts you come across. Some parts might be worth a discussion towards a general api though.

Thanks for the charming words 💚

from crystal-mysql.