Comments (3)
And to be clear that means crystal-mysql would not be able to guarantee the type of a scalar value. Which is not great. But I think this can be handled by crystal-db directly if we allow some type conversions (ie: rs.read
returned an Int32
, but the user is calling rs.read(Int64)
, I imagine this to allow runtime type mismatch since that is already the case if db types are different from what user wrote in the code).
from crystal-mysql.
I'm fine accepting maria-db issues. It would like it to be an alternative for users.
Those specs that are failing are because it seems mariadb and mysql do not agree on the type on a select 1
.
The following works with maria-db (but will not with mysql)
sample_value 1, "int", "1" # , type_safe_value: false
sample_value 1_i64, "bigint", "1", type_safe_value: false
# ...
sample_value -1, "int", "-1" # , type_safe_value: false
sample_value -1_i64, "bigint", "-1", type_safe_value: false
With type_safe_value: true
(default) the select_scalar_syntax
will be used with the expression directly, in this case select 1
and select -1
. And the specs will validate the result set should read the first column of the first row will have the same value and type as the first argument. So mysql returns something that translates to Int64 while maria-db something that translates to Int32.
I could not find any documentation regarding this differences.
So the actionable thing is probably to:
- Add mariadb to the CI
- Make specs pass on both
from crystal-mysql.
Hello @bcardiff, thanks for your response and your patience, missed this in my inbox.
Thanks for providing the details, I was able to find the reference about that change in MDEV-16347, indicating that the change was intentional from MDEV-12619.
Perhaps the spec/test can be adjusted to evaluate first the data type of CREATE TABLE t1 AS SELECT 1 AS c1
and from there determine the type?
Cheers.
from crystal-mysql.
Related Issues (20)
- Unexpected EOF on ubuntu aarch64 HOT 2
- Generic `Exception`s raised in `MySql::Connection` HOT 6
- packet 254 not implemented -- still struggling with
- Release a new version HOT 2
- Crystal 0.24 HOT 4
- call Store procedure HOT 1
- "Client does not support authentication protocol requested by server; consider upgrading MySQL client (Exception)" HOT 7
- BINARY and VARBINARY columns can only be read as string
- connection failure to mysql 8 HOT 11
- how to connect to mysql via unix_socket?
- Support JSON data type
- Register custom decoder? HOT 2
- Inconsistent return value types HOT 2
- Add support for bit(1) reading
- values of UInt8 data types get converted to 125 HOT 8
- Cannot read query_one result as Bool HOT 4
- Shards Issue : install does not work HOT 6
- Release 0.8.0 missing HOT 1
- Missing block in decl_type *Blob ?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from crystal-mysql.