support TINYINT(1) about crystal-mysql HOT 5 CLOSED

It'd may be nice to treat TINYINT(1) as a bool... especially for json output. Thoughts?

from crystal-mysql.

I've added tiny int to mysql driver. As mysql doesn't support Bool type I've created this converter for json. The pull request is still outstanding, my fork is here - https://github.com/crisward/crystal-mysql

 class Int8ToBool
    def to_json(value : Int8, io : IO)
      val = value > 0 ? true : false
      io << val
    end

    def from_json(value : JSON::PullParser) : Int8
      val = value.read_bool
      val == true ? 1_i8 : 0_i8
    end
  end

You can use it in your json mapping with

ie

    JSON.mapping({
      somefield:     {type: Int8, nilable: true, converter: Int8ToBool.new},
    })

from crystal-mysql.

Yes, I think tinyint should be a Bool, not Int8

from crystal-mysql.

The mysql driver returns an int8, a tinyint can store 0-256, so does have other uses.
(http://dev.mysql.com/doc/internals/en/binary-protocol-value.html#packet-ProtocolBinary::MYSQL_TYPE_TINY)

I think leaving it as an int8 and converting to a bool in the json layer seems to make most sense. I personally only use tiny int for bool's but I can imagine other uses.

from crystal-mysql.

#15 was merged.
As @crisward says tinyint is always 1 byte so it won't be right to treat them as booleans.
Int8ToBool converter it the way to go.

from crystal-mysql.