Comments (6)
Thanks @loktionovam and @RichardWardle, I think it's fixed now, I've released a 0.13.0 with the change in. Please let me know either way, and re-open this if it isn't working for you.
from argocd-lovely-plugin.
Thanks for the report - haven't used OCI repos myself so haven't hit it. This doesn't seem too hard. I'll see what I can do.
from argocd-lovely-plugin.
I have made a change to attempt to help with this, but I don't know of any public OCI repo to test against. @loktionovam , if you know of one, please let me know, otherwise the next release will have this change in.
from argocd-lovely-plugin.
Hey @Joibel
You should be able to test with (what i have done below on Argocd v2.5.5) - https://gallery.ecr.aws/karpenter/karpenter
.
├── README.MD
├── helm
│ ├── Chart.yaml
│ ├── env.txt
│ └── values.yaml
└── kustomize
├── kustomization.yml
├── nodetemplate.yml
└── provisioners.yml
Chart.yaml looks like:
apiVersion: v2
version: 1.0.0
name: karpenter
dependencies:
- name: karpenter
version: v0.22.1
repository: oci://public.ecr.aws/karpenter
When using stable we also see the same issue as loktionovam:
rpc error: code = Unknown desc = `argocd-lovely-plugin` failed exit status 1: 2023/01/14 01:47:39 exit status 1: Error: looks like "oci://public.ecr.aws/karpenter" is not a valid chart repository or cannot be reached: object required
When using your latest push ghcr.io/crumbhole/argocd-lovely-plugin:5c28271c2630001784a23828adc34c5261dc6784 I see the following (hard refresh done and app deleted and recreated to avoid any caching issues):
rpc error: code = Unknown desc = `argocd-lovely-plugin` failed exit status 1: 2023/01/14 01:58:04 exit status 1: Error: no repositories found. You must add one before updating
If you remove the oci:// from the Chart.yaml it complains which is to be expected: Error: could not find protocol handler for:
Deploying the helm chart straight from ArgoCD works fine (currently we deploy Karpenter via helm and then use another app to deploy our config using wave sync precedence). A Snip of our argocd app that works without utilizing the lovely plugin looks similar to:
source:
chart: karpenter
repoURL: public.ecr.aws/karpenter
targetRevision: v0.22.1
helm:
values: |
serviceAccount:
Happy to provide any other information you may want or test another version!
from argocd-lovely-plugin.
@Joibel Hello, you can use any OCI docker registry, for example dockerhub
helm push ./cloudnative-pg-0.16.0.tgz oci://registry-1.docker.io/loktionovam
Pushed: registry-1.docker.io/loktionovam/cloudnative-pg:0.16.0
Digest: sha256:86aaa0adb010b805ef0dea49cdeaa6eabe9a235b16c7d90d91f81e726be9b1fb
helm pull oci://registry-1.docker.io/loktionovam/cloudnative-pg
Pulled: registry-1.docker.io/loktionovam/cloudnative-pg:0.16.0
Digest: sha256:86aaa0adb010b805ef0dea49cdeaa6eabe9a235b16c7d90d91f81e726be9b1fb
from argocd-lovely-plugin.
Thanks @loktionovam and @RichardWardle, I think it's fixed now, I've released a 0.13.0 with the change in. Please let me know either way, and re-open this if it isn't working for you.
Tested this against the karpenter OCI repo and worked well - thanks heaps @Joibel!
from argocd-lovely-plugin.
Related Issues (20)
- LOVELY_HELM_VALUES don't respect values files in upper directory HOT 8
- Fix it so that LOVELY_ALLOW_GITCHECKOUT is never needed HOT 1
- sidecar plugins of lovely plugin HOT 3
- Issue with local run HOT 2
- lovely-plugin can't download dependencies from google artifact registry HOT 3
- ghcr.io/crumbhole/lovely-vault-plugin has no argocd-vault-plugin binary HOT 3
- bug: Environment variables from LOVELY_HELM_MERGE are expanded HOT 9
- Question: How to use argocd-vault-plugin for multiple Vault instances HOT 5
- argocd-vault-plugin container includes invalid binary HOT 1
- v0.20.0 - all plugins have the same default name HOT 4
- Environment variables LOVELY_HELM_REPO_ADD_PARAMS throwing Error: helm repo add requires 2 arguments HOT 4
- ci: CI always fails for users who offer PRs HOT 2
- CRDs not included in helmfile template processor HOT 3
- Can't run command as part of helm template HOT 2
- 401 unauthorized - Unable to pull OCI Registry images on Lovely CMP 0.22.1 (Helm 1.13.1) HOT 2
- Ytt crashes in lovely-ytt HOT 2
- Remove argocd-cm vestiges from installation examples HOT 7
- Cant add helm repo if using helmfile processor HOT 5
- Help wanted with dynamic kustomize resource configuration. HOT 1
- Adding a possibility to ignore directories HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from argocd-lovely-plugin.