Git Product home page Git Product logo

Comments (6)

Joibel avatar Joibel commented on September 23, 2024 1

Thanks @loktionovam and @RichardWardle, I think it's fixed now, I've released a 0.13.0 with the change in. Please let me know either way, and re-open this if it isn't working for you.

from argocd-lovely-plugin.

Joibel avatar Joibel commented on September 23, 2024

Thanks for the report - haven't used OCI repos myself so haven't hit it. This doesn't seem too hard. I'll see what I can do.

from argocd-lovely-plugin.

Joibel avatar Joibel commented on September 23, 2024

I have made a change to attempt to help with this, but I don't know of any public OCI repo to test against. @loktionovam , if you know of one, please let me know, otherwise the next release will have this change in.

from argocd-lovely-plugin.

RichardWardle avatar RichardWardle commented on September 23, 2024

Hey @Joibel

You should be able to test with (what i have done below on Argocd v2.5.5) - https://gallery.ecr.aws/karpenter/karpenter

.
├── README.MD
├── helm
│   ├── Chart.yaml
│   ├── env.txt
│   └── values.yaml
└── kustomize
    ├── kustomization.yml
    ├── nodetemplate.yml
    └── provisioners.yml

Chart.yaml looks like:

apiVersion: v2
version: 1.0.0
name: karpenter
dependencies:
- name: karpenter
  version: v0.22.1
  repository: oci://public.ecr.aws/karpenter

When using stable we also see the same issue as loktionovam:

rpc error: code = Unknown desc = `argocd-lovely-plugin` failed exit status 1: 2023/01/14 01:47:39 exit status 1: Error: looks like "oci://public.ecr.aws/karpenter" is not a valid chart repository or cannot be reached: object required

When using your latest push ghcr.io/crumbhole/argocd-lovely-plugin:5c28271c2630001784a23828adc34c5261dc6784 I see the following (hard refresh done and app deleted and recreated to avoid any caching issues):

rpc error: code = Unknown desc = `argocd-lovely-plugin` failed exit status 1: 2023/01/14 01:58:04 exit status 1: Error: no repositories found. You must add one before updating

If you remove the oci:// from the Chart.yaml it complains which is to be expected: Error: could not find protocol handler for:

Deploying the helm chart straight from ArgoCD works fine (currently we deploy Karpenter via helm and then use another app to deploy our config using wave sync precedence). A Snip of our argocd app that works without utilizing the lovely plugin looks similar to:

  source:
    chart: karpenter
    repoURL: public.ecr.aws/karpenter
    targetRevision: v0.22.1
    helm:
      values: |
        serviceAccount:

Happy to provide any other information you may want or test another version!

from argocd-lovely-plugin.

loktionovam avatar loktionovam commented on September 23, 2024

@Joibel Hello, you can use any OCI docker registry, for example dockerhub

helm push  ./cloudnative-pg-0.16.0.tgz oci://registry-1.docker.io/loktionovam                                                                                                                               
Pushed: registry-1.docker.io/loktionovam/cloudnative-pg:0.16.0
Digest: sha256:86aaa0adb010b805ef0dea49cdeaa6eabe9a235b16c7d90d91f81e726be9b1fb

helm pull oci://registry-1.docker.io/loktionovam/cloudnative-pg                                                                                                                                             
Pulled: registry-1.docker.io/loktionovam/cloudnative-pg:0.16.0
Digest: sha256:86aaa0adb010b805ef0dea49cdeaa6eabe9a235b16c7d90d91f81e726be9b1fb

from argocd-lovely-plugin.

RichardWardle avatar RichardWardle commented on September 23, 2024

Thanks @loktionovam and @RichardWardle, I think it's fixed now, I've released a 0.13.0 with the change in. Please let me know either way, and re-open this if it isn't working for you.

Tested this against the karpenter OCI repo and worked well - thanks heaps @Joibel!

from argocd-lovely-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.