LOVELY_HELM_VALUES don't respect values files in upper directory about argocd-lovely-plugin HOT 8 CLOSED

Please have a look at the LOVELY_ALLOW_GITCHECKOUT option and associated documentation/caveats and see if that helps.

from argocd-lovely-plugin.

Seems to be working. According documentation it means that I have to set lockRepo: true for the plugin if more than one ArgoCD Application reference the same Git repository?

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: test-argocd-plugin
  namespace: argocd
spec:
  destination:
    url: https://kubernetes.default.svc
    namespace: default
  project: default
  source:
    plugin:
      name: argocd-lovely-plugin-v1.0
      env:
        - name: LOVELY_HELM_NAME
          value: foo
        - name: LOVELY_HELM_REPO_ADD_PARAMS
          value: --insecure-skip-tls-verify
        - name: LOVELY_HELM_VALUES
          value: "../values/custom-values.yaml"
+       - name: LOVELY_ALLOW_GITCHECKOUT
+         value: "true"
    path: test-argocd-plugin
    repoURL: '<git repo>'
    targetRevision: master

from argocd-lovely-plugin.

Yes, that is correct, you should set lockRepo: true

from argocd-lovely-plugin.

Could you give me please example manifest of ConfigManagementPlugin with the lockRepo: true for the argocd-lovely-plugin? Or just hint where to set this option? Thanks

EDIT:
Could it be like this?

apiVersion: argoproj.io/v1alpha1
kind: ConfigManagementPlugin
metadata:
  name: argocd-lovely-plugin
spec:
  version: v1.0
  generate:
    command: ["argocd-lovely-plugin"]
  allowConcurrency: true
  lockRepo: true

from argocd-lovely-plugin.

Ah, if you're using lovely as a sidecar you don't need lockRepo, it's only needed for configmap plugins. Just carry on as you were.

from argocd-lovely-plugin.

I need to sort out the documentation etc better for sidecars. Apologies for wasting your time.

from argocd-lovely-plugin.

Yes basically I install argocd via original Helm Chart directly from argo-helm repo and I use these values

repoServer:
  extraContainers:
    - name: lovely-plugin
      command: [/var/run/argocd/argocd-cmp-server]
      image: ghcr.io/crumbhole/argocd-lovely-plugin-cmp-vault:0.18.0
      envFrom:
        - secretRef:
            name: argocd-vault-replacer-credentials
      securityContext:
        runAsNonRoot: true
        runAsUser: 999
      volumeMounts:
        - mountPath: /var/run/argocd
          name: var-files
        - mountPath: /home/argocd/cmp-server/plugins
          name: plugins
        - mountPath: /tmp
          name: tmp-dir
  volumes:
    - name: tmp-dir
      emptyDir: {}

from argocd-lovely-plugin.

I'm closing this as I think it's all done. Please re-open if I'm wrong.

from argocd-lovely-plugin.