Git Product home page Git Product logo

Comments (6)

Joibel avatar Joibel commented on September 23, 2024

Please see #66 and the resolution of that. See if that works for you.

from argocd-lovely-plugin.

shanproofpoint avatar shanproofpoint commented on September 23, 2024

@Joibel thank you! whole sale change in functionality is unexpected XD
Btw how does copying the directory prevent racing conditions tho?
when you merge it back into the final collection of yaml, the newly processed thing may step on something already generated earlier by another thread no?


on another note having trouble finding documentation and example of lovely plugin post processors (plugins on yaml)
will continue hunting around...

from argocd-lovely-plugin.

Joibel avatar Joibel commented on September 23, 2024

It's currently not the default behaviour. I'd like to remove the requirement to configure this, but I haven't decided how.
The copy of the directory is not to prevent race conditions. It is to prevent lovely running and modifying the directory, and then being asked to run again in the same directory, where the files will have been already modified by the first run.
Lovely doesn't merge it back into anything, it takes the yaml, renders it to the final version of yaml in memory and feeds that in memory copy directly to ArgoCD to put in your cluster. ArgoCD will separate up the individual application rendering to prevent the applications from interfering with each other. The lock is just because we're performing git operations to reset the repository back to how it should be, and ArgoCD tell us to take that lock if we want to do that.

Plugin documentation is here and there is a noddy example here (see env.txt for configuring it)

from argocd-lovely-plugin.

shanproofpoint avatar shanproofpoint commented on September 23, 2024

Thank you for this explanation Joibel! I now understand should the parent location's contents change, it can make the rendering of this application's yaml inconsistent.

from argocd-lovely-plugin.

shanproofpoint avatar shanproofpoint commented on September 23, 2024

(and thus "locking" on the plugin may not be a heavy as i thought it would be)

from argocd-lovely-plugin.

shanproofpoint avatar shanproofpoint commented on September 23, 2024

I apologize. I was confused. will recheck. thanks again Joibel!

from argocd-lovely-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.