crowdcomms / faker-e164 Goto Github PK

View Code? Open in Web Editor NEW

21.0 4.0 10.0 26 KB

Faker provider to generate E164 Phone Numbers

License: Apache License 2.0

Python 100.00%

python test-data test-data-generator

faker-e164's People

Contributors

Stargazers

Watchers

Forkers

aljp afdecastro879 mattjegan goodspark pkuznets get-apryl galabid valentinschabschneider arpitjain799

faker-e164's Issues

syntax error

  File "faker_e164/providers.py", line 64
    def _get_e164_numerify_pattern(self, region_code: str, is_possible=True):
                                                    ^
SyntaxError: invalid syntax

E164Provider.safe_e164 produces incompatible phone numbers

I've recently been using Django Phone Number Field and have found that in my tests, using fake.safe_e164() is occasionally trigging a validation error from the PhoneNumberField serializer field.

I'll need to do some more testing to find the exact values that are causing this as it might be an issue for the library rather than this provider but thought it was worth reporting.

Using faker-e164 changes the logging level of the program

First of all, thanks for developing this provider, it is very useful since faker sometimes generate phone numbers that are not e.164 compliant.

Here logging level is set to an env variable LOGLEVEL, I'm not sure if that is an error or wanted behavior, but I think that is unexpected for a library that has nothing to do with logging.