Git Product home page Git Product logo

books's People

Contributors

crowdagger avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

books's Issues

Cleaning up the generated TOC

Hi,

I was able to get a cleaner output of the TOC by using the merged .md files generated by the nostarch.sh script in the book repo:
screen shot 2017-10-29 at 2 49 14 pm

And by modifiying a bit the .book config file

As mentioned by #3, the img/ prefix in ch20-00-final-project-a-web-server.md needs to be removed so that the build doesn't fail.

This is the output of applying these changes with the 2017-10-28 7db393d version of the book:

PDF
EPUB
HTML

Validation errors

I get the following errors when I submit trpl2.epub to epubcheck:

ERROR(RSC-005): trpl2.epub/OEBPS/chapter_013.xhtml(186,17): Error while parsing file 'attribute "start" not allowed here; expected attribute "class", "dir", "id", "lang", "style", "title" or "xml:lang"'.
ERROR(RSC-005): trpl2.epub/OEBPS/chapter_068.xhtml(26,17): Error while parsing file 'attribute "start" not allowed here; expected attribute "class", "dir", "id", "lang", "style", "title" or "xml:lang"'.
ERROR(RSC-007): trpl2.epub/OEBPS/chapter_004.xhtml(61,173): Referenced resource could not be found in the EPUB.
ERROR(RSC-007): trpl2.epub/OEBPS/chapter_004.xhtml(80,422): Referenced resource could not be found in the EPUB.
ERROR(RSC-007): trpl2.epub/OEBPS/chapter_004.xhtml(87,313): Referenced resource could not be found in the EPUB.
ERROR(RSC-007): trpl2.epub/OEBPS/chapter_004.xhtml(88,182): Referenced resource could not be found in the EPUB.
ERROR(RSC-007): trpl2.epub/OEBPS/chapter_004.xhtml(97,235): Referenced resource could not be found in the EPUB.
ERROR(RSC-007): trpl2.epub/OEBPS/chapter_004.xhtml(97,422): Referenced resource could not be found in the EPUB.
ERROR(RSC-007): trpl2.epub/OEBPS/chapter_004.xhtml(100,323): Referenced resource could not be found in the EPUB.
ERROR(RSC-007): trpl2.epub/OEBPS/chapter_004.xhtml(316,102): Referenced resource could not be found in the EPUB.
ERROR(RSC-007): trpl2.epub/OEBPS/chapter_020.xhtml(90,353): Referenced resource could not be found in the EPUB.
ERROR(RSC-007): trpl2.epub/OEBPS/chapter_020.xhtml(155,349): Referenced resource could not be found in the EPUB.
ERROR(RSC-007): trpl2.epub/OEBPS/chapter_020.xhtml(184,393): Referenced resource could not be found in the EPUB.
ERROR(RSC-007): trpl2.epub/OEBPS/chapter_028.xhtml(19,173): Referenced resource could not be found in the EPUB.

Release download links

Feel free to close or delete this after reading:

I recommend migrating the epub itself into a release so that we can go there to download as opposed to the readme.md... or maybe as an alternative instead.

Thank you for making this into an epub!

Unable to build trpl2 278f4db5

The latest version of master of trpl (278f4db5489fe0ca791f4f93b2fca858ae9cdc90) does not build with the following error:

Error: Error rendering html: trpl/second-edition/src/ch20-00-final-project-a-web-server.md: Could not find file 'trpl/second-edition/src/img/img/trpl20-01.png' for image

The complete error output is in this gist.

The version from the submodule checked in here, 90bc937c05c5fd53dcf91715a0fb3a06dd8366e5, does work fine, though. It looks like they changed

-![hello from rust](hello.png)
+![hello from rust](img/trpl20-01.png)

removing the img/ makes crowbook work again.
I'm not sure, whether the error lies with crowbook or the original book sources (which are unit tested, though, and seem to pass those...). Could you please investigate that?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.