seekMezzSpill changes input behavior but not yet reflected in unit tests. Sell border will occur at the first tick in the previous bitmap.

Currently LiquidityCurve test contract facade is not enabled.

Current initPool function is not ready for production. Let's user set anything they want. Have to upgrade before release

Recent changes broke gas benchmark tests.

Add unit tests for ambient mint and burn functions

Currently the unit tests in testPool.inf.ts aren't passing.

We're deferring working on them, because it's likely that initializing the pool will require permanently locked liquidity. Therefore we may not need to test for 0 or low liquidity situations.

Add event logs where appropriate. Not in gas hot path, but in certain out-of-band situations. Especially related to protocol authority and fee collection.

Add unit tests for pool directives which combine multiple operations on a single pool. E.g. mint and swap, mint and multiple bookends, postPassive, etc.

Hello there!

It seems that the commit 73440a9 introduced a typescript error in some TestKnockoutCounter.ts unit tests, since the name hre is not known.

When writing tests in Typescript, the globally injected hre will not be recognized (confirmed by the docs), so one way to solve this would be to either import hre through import hre from "hardhat" or, since only the ethers module is being used, just import { ethers } from "hardhat" and changing usages accordingly would work. I've done this locally some days ago to be able to run the tests.

Let me know what you think. Cheers!

Check the whole codebase for unsafe casts, and replace with safe cast versions

Initializing a position shouldn't be costless for the caller. The caller should be required to burn some small amount of ambient liquidity that's permanently locked in the pool. Uniswap V2's model is to require a minimum of 1000 ambient seeds. We probably want to do something like that.

Test that CrocSwapDex directive consolidates multiple pools correctly within a single pair.

• Change owner
• Disburse funds
• Pool settings
• Pool template settings
• Init lock threshold

• Trading before init
• Initializing a non-template
• Setting a template as non-authority
• Initializing without paying the burn fee

Add Slither as a testing framework

• Pool Settings
• Protocol Fees

Add code coverage to test suite.

Positions have timestamp attached, test that it's being set correctly. Also make sure priority is correctly calculated: reset on liquidity increase, keep the same on decreases.

It seems suspicious that protocol fees may not be getting accumulated in the gas benchmark suite.

Recent changes broke TestPool.bump.ts and TestPool.dance.ts

The tick census unit tests don't currently test to make sure that different poolIdx arguments avoid collision. The test contract hardcodes a single idx, so we'd have to support calling with multiple idxs.

Add Echidna-based fuzzing tests to the test suite.

Add tests for re-entrancy to the TestPool.sec test suite.

Including security test to make sure we can't withdraw more than is available.

Not publicly exposed, but complex logic that isn't directly tested anywhere.

croc's contracts are fairly abstract, so devs often need to jump in and follow the source code to understand how many of the features work

although well documented, i think its better to format comments into the NatSpec standard, so the comments can be picked up by toolings automatically. for example, etherscan injects the comments into the "contract ui" for all documented public methods, vscode shows the entire comments on hover, and docs can be auto generated as well

not sure if etherscan allows reverifying contract source code

currently, the comments start with /*

vs

Untested public functions include:

• deltaBase/deltaQuote
• priceToTokenPrecision
• isFlowInput

Review to see what is no longer relevant and fix rest (if any)

Upgrade to most recent version of Solidity.

Pay careful attention to breaking changes. In particular, I believe we rely on overflow functionality in one of the libraries or mixins.

Remove Duplicate Import: The contract CrocSwapDex is importing MarketSequencer.sol twice. You can remove one of the duplicate import statements to clean up the code.

Use the Latest Solidity Version: Since the current version of Solidity is 0.8.19, consider using the latest stable version (at the time of your implementation) to take advantage of new features and bug fixes.

Consider Separating Contracts: If the contract size is becoming too large, consider breaking it down into smaller contracts with logical separations. This can help improve code maintainability and readability.

Assign me this issue, so i can solve them. This is a brilliant contract btw

Verify that a deflationary or trapdoor token that under-sends a transferFrom will fail.