criticalmaps / criticalmaps-ios Goto Github PK

On my last test I've found out that the app stops sending gps data in background mode after a while, which is not good :(

The current launch screen artwork is too small. The correct size is defined in https://github.com/criticalmaps/criticalmaps-design/tree/master/ios

maybe it would be easier to see whats going on, if the own position icon would be on top.

Our users should get some more information about how the friends feature works. #96

• Anyone who has the ID/QR code will know where you are when the app is running
• Without knowing the ID no-one should be able to track you
• When you reinstall the app your friends will have to re-add you

We could also add an empty state when you have no friends yet.

Any good ideas how to do this @zutrinken?

It would be nice to support the increase contrast feature of iOS.

We could do that by listening to https://developer.apple.com/documentation/uikit/uiaccessibility/1615087-isdarkersystemcolorsenabled to change the colors or use asset catalog but that only works on iOS 13 +

would be nice if the chat would tell you how old a message is.

i wrote a class that converts a timestring to "bla minutes ago", "bla seconds ago" and so on...

https://github.com/stephanlindauer/criticalmaps-android/blob/7c3a2cba6f9ddbd5cb76f94f7c809bd1be8b8707/app/src/main/java/de/stephanlindauer/criticalmaps/helper/TimeToWordStringConverter.java

New rules without images. New illustrations will follow in a future update.

Title

Richtlinien

Guidelines

1

Kommunikation

Gute Kommunikation ist essentiell für eine funktionierende Critical Mass. Viele Teilnehmer sind zum ersten mal dabei. Sprecht miteinander und erklärt ihnen die Verhaltensregeln. Informiert eure Mitfahrer wenn abgebogen oder gehalten wird. Warnt euch gegenseitig bei Gefahren und bedankt euch wenn Leute Kreuzungen sichern (korken).

Communication

Good communication is essential for a proper Critical Mass. Remember that many of your fellow riders are there for the first time. Reach out and explain the rules of the mass if anyone seems unclear. Let people know when you are stopping or turning. Warn riders of any danger and give some thanks to those who are protecting the intersections (corking).

2

Hab Spass

Die Critical Mass sollte sicher sein und Spass machen. Manche Fahrer werden wütend und aggressiv. Erklärt das Konzept umstehenden und macht Verbündete aus ihnen. Behaltet ein ruhiges Gemüt und lasst aggressive Situationen nicht eskalieren.

Good Vibes

The Critical Mass should be fun and safe for everyone. Some drivers get angry and aggressive. Try your best to explain the Critical Mass to bystanders and make allies out of them. Never escalate any aggression and always keep the situation chill.

3

Gegenverkehr

Die Critical Mass ist als ein Fahrzeug anzusehen. Bleibt auf eurer Fahrspur und fahrt nicht in den Gegenverkehr! Damit bringt ihr euch und andere Verkehrsteilnehmer in Gefahr.

Oncoming Traffic

The Critical Mass should look and act like one unified vehicle driving on the street. Stick to your own lane and never ride into the opposite lane of oncoming traffic. This can be incredibly dangerous for riders in the mass.

4

Geschwindigkeit

Damit die Critical Mass nicht auseinander gerissen wird, ist es wichtig, ein gemäßigtes Tempo beizubehalten und vorne nicht zu schnell zu fahren. Das verhindert das Bilden von Lücken. Wenn doch mal eine Lücke entsteht, so versucht aufzuschließen!

Pace Yourself

Keeping an even pace is essential to keeping one unified mass and avoiding any interference from competing traffic. To avoid cracks in the mass, don't ride too fast. If you see too much space starting to form, try to fill in immediately.

5

Geschlossener Verband

Fahrt an Kreuzungen nie zwischen stehenden Autos hindurch, sondern wartet dahinter. Sollte doch mal ein Fahrzeug in der Critical Mass stecken, leitet es hinaus. Das Blockieren verursacht nur mehr Stau und stört die Weiterfahrt. Als Kopf der Critical Mass darfst du nur bei Grün über die Ampel. Sobald der Verband einmal die Kreuzung überquert hat, müssen alle folgenden Radfahrer auch bei Rot weiterfahren.

Unified Mass

Never ride between standing cars at intersections. If a car gets itself stuck in the mass, just let it out. Blocking cars only causes more traffic to back up. Those leading the Critical Mass should only pass a traffic light if it is green. Once the mass is moving through an intersection, others should continue to follow, even when the light has turned red.

6

Blaulicht

Blockiert niemals Krankenwagen oder andere Einsatzfahrzeuge! Macht Platz, fahrt an den Rand und bildet eine Gasse. Prüft eure Umgebung und fahrt erst weiter wenn das Weiterkommen der Einsatzfahrzeuge gewährleistet ist.

Emergency Vehicle

Never block an emergency vehicle! Ride along the edges and create a lane where the vehicle can pass. Be absolutely sure the vehicle has safely passed before riding as usual.

7

Kreuzungen (Korken)

Korken ist das Absichern der Critical Mass an Kreuzungen. Stellt euch mit eurem Rad direkt vor die Autos und versperrt ihnen den Weg in die Critical Mass. Ein Fahrrad ist meistens nicht genug. Arbeitet zusammen um die Kreuzungen gemeinsam mit anderen Radfahrern zu sichern und löst euch gegenseitig ab. Manche Autofahrer reagieren uneinsichtig und aggressiv. Haltet an und helft die Situation zu schlichten. Klärt sie ruhig und sachlich über die StVo und Critical Mass auf.

Intersections (Corking)

Corking is protecting the Critical Mass at intersections. Stand at the intersection and use your bicycle to block cars from driving into the mass. Sometimes one bicycle is not enough. Work together to block the intersections with many bicycles and relieve those who have been corking for a long time. Some drivers get angry and aggressive for being blocked. Stop and help to calm the situation down. Explain the Critical Mass and traffic regulations calmly and factually.

8

Bürgersteig

Fahrt nicht auf dem Bürgersteig! Als schwächstes Glied im Netz der Verkehrsteilnehmer gilt den Fußgängern gegenüber besondere Rücksicht. Reclaim the Streets, nicht die Gehwege.

Sidewalk

Never ride on the sidewalk! Pedestrians are the weakest link in the traffic chain, and we need to look out for them. Reclaim the streets, not the sidewalk.

9

Polizeibegleitung

Oft wird die Critical Mass von der Polizei begleitet. Sie sichern kritische Kreuzungen und zähmen wütende Autofahrer. Als Kopf der Critical Mass ist es vorteilhaft (je nach Laune und Situation) zu kooperieren und die gewünschte Route der Polizei mitzuteilen.

Police Escort

The Critical Mass will be escorted by the police quite often. They protect intersections and tame raging drivers. As the head of the Critical Mass it can be an advantage (depending on your mood and situation) to cooperate and communicate the desired route to the police.

setup deep linking according to https://developers.facebook.com/docs/applinks/ios
so we can link to the app straigt from facebook or our website

We often get the following error message for our CI builds

[!] Operation not permitted - /Users/travis/Library/Application Support/CallHistoryTransactions (Errno::EPERM)

manually restarting the build often resolves the issue but it's something we should investigate and fix

Hey!

I'd like to (ab)use this wonderful app for hitchhiking, for this purpose it would make sense to run a custom server. What do you think about adding a hidden way to change the API server address?

Switch keyboard to emoji, the chat input moves to the bottom behind the keyboard.

Chat and Twitter cells don't have the right paddings / margins and font sizes / line height. Defined in sketch.

Chat:

Is:

Should:

Specs:

Padding: 16px
Date: 15px / 16px - Bold #262626
Margin between date and message: 4px
Message: 17px / 24px - Regular #45474D

Twitter:

Is:

Should:

Specs:

Padding: 16px
Avatar: 40x40px - Inner border: 1px rgba(55,64,82,0.18)
Margin between avatar and text: 16px
Name: 15px / 16px - Bold #262626
Margin between name and username: 4px
Username: 15px / 16px - Regular #909399
Date: 13px / 16px - Medium #45474D
Margin between name and message: 4px
Message: 17px / 24px - Regular #45474D

Hi. I just discovered this repo and would like to participate.
I would like to know if there is a reason that the the deployment target is iOS 8.0?

I think the codebase could benefit from even little things like StackViews.
Regards

It's possible to send an empty message. Send button should be disabled until there's at least one character.

When the map got moved and isn't following my own position the location icon should be outlined as in apple or google maps.

maybe it would make it more obviuos that its clickable if there would be a border or background color.

Might be related to mono0926/LicensePlist#105

... to share pictures with the world :)

We are currently updating the Apps content every 12 seconds or after the user send a message as it's using the same API. This may result in an outdated map especially if a request failed because we are currently waiting another 12 seconds for the next try at which point the app might already be in the background.

It would be nice to be smarter about updating the poll the data every 6 seconds if the app is in foreground and every 12 seconds in background (maybe as well in lower power/ data mode ?). Additionally we should retry sooner, if possible as soon as possible (maybe check for internet connection on iOS 12+ devices https://developer.apple.com/documentation/network/nwpathmonitor)

Currently, the deviceID which is Send to server is constant and only changes if a user reinstalls the app. We should change this I’d every 24 hours similar to what the android client does https://github.com/criticalmaps/criticalmaps-android/blob/master/app/src/main/java/de/stephanlindauer/criticalmaps/model/UserModel.java , to prevent that users can be tracked over multiple sessions and events

Observing mode is for users that want to look at the map without participating in the critical mass.

"Setting the background color on UITableViewHeaderFooterView has been deprecated. Please set a custom UIView with your desired background color to the backgroundView property instead."

Add Snapshot testing library https://github.com/pointfreeco/swift-snapshot-testing (it supports installation with SPM).

Pros:

• automatically test how all the screens/views we need to test look on different devices.
• automatically test how all the screens/views we need to test look in both light and dark modes.
• automatically test how all the strings on the screens/views we need to test look
• automatically test how all the strings on the screens/views we need to test look in different localizations (if we have different localizations)
• don't need to submit before/after screenshots with every PR, because it will be tested automatically

It would be nice to have interactive links in chat messages and additionally interactive hashtags and username in the Twitter integration that link to the browser or twitter.

We are currently don't have a dedicated environment for testing are directly hitting the production backend for debugging and testing. This works for most use cases.

However, some scenarios require a lot of activity on the map. If would be nice if we could mock the data that the App is using locally for test purposes or even replay recorded backend responses.

Testdata can be found here https://github.com/criticalmaps/criticalmaps-testdata

It would be nice to have a infrastructure for UI tests. We could use that for testing but also screenshot to have a quick overview how the app looks like in different languages and device types

Modal presentations

iOS 13 has a new default modal transition.

Do we need some design changes here @zutrinken . Using the old full screen presentation would also be possible

Colors - Darkmode

Our Theming/ Darkmode implementation breaks for some components. Maybe we should adopt to the system Darkmode for iOS 13 Users.

Swift Package Manager

It would be nice in my opinion to replace our current dependency manager cocoapods with the Swift Package Manager that is built into Xcode 11. That would allow us to build the project without needing any additional tooling

show a notification bubble for new unread messages

Some Rule artworks are not displayed in the correct ratio

Repro steps

1. Navigate to Rules
2. Open "When Driving at the head .. "

Actual Result:

Expected Result:

It would be nice to share the app to social media channels.

Triggering the compass on the map while being in following mode (location arrow with line pointing north) does end following mode, but the tabbar icon stays in following mode.

Steps to reproduce:

1. Go to settings
2. Deactivate GPS
3. Go to chat
4. Type a message
5. Press 'send'

Result: App crashes

Looks like the segmentedControl hides under the toolbar for example on iOS 10.3.1

Prettified Error

[LayoutConstraints] Unable to simultaneously satisfy constraints.
Probably at least one of the constraints in the following list is one you don't want.
Try this:
(1) look at each constraint and try to figure out which you don't expect;
(2) find the code that added the unwanted constraint or constraints and fix it.
(
"<NSLayoutConstraint:0x600001778d20 CMAppLogo.height == 56 (active, names: CMAppLogo:0x7f8631f535c0 )>",
"<NSLayoutConstraint:0x600001778050 UILayoutGuide:0x600000e2ea00'UIViewSafeAreaLayoutGuide'.bottom == UIStackView:0x7f8631f52b60.bottom + 32 (active)>",
"<NSLayoutConstraint:0x60000177b070 UIStackView:0x7f8631f52b60.top == UILayoutGuide:0x600000e2ea00'UIViewSafeAreaLayoutGuide'.top + 24 (active)>",
"<NSLayoutConstraint:0x60000177ea80 'UISV-canvas-connection' UIStackView:0x7f8631f52b60.top == CMAppLogo.top (active, names: CMAppLogo:0x7f8631f535c0 )>",
"<NSLayoutConstraint:0x60000177fbb0 'UISV-canvas-connection' V:[CMAppLogo]-(0)-| (active, names: CMAppLogo:0x7f8631f535c0, '|':UIStackView:0x7f8631f52b60 )>",
"<NSLayoutConstraint:0x60000177fa70 'UIView-Encapsulated-Layout-Height' CriticalMaps.SettingsFooterView:0x7f8631f524a0.height == 156 (active)>",
"<NSLayoutConstraint:0x600001779360 'UIViewSafeAreaLayoutGuide-bottom' V:[UILayoutGuide:0x600000e2ea00'UIViewSafeAreaLayoutGuide']-(0)-| (active, names: '|':CriticalMaps.SettingsFooterView:0x7f8631f524a0 )>",
"<NSLayoutConstraint:0x60000177b660 'UIViewSafeAreaLayoutGuide-top' V:|-(0)-[UILayoutGuide:0x600000e2ea00'UIViewSafeAreaLayoutGuide'] (active, names: '|':CriticalMaps.SettingsFooterView:0x7f8631f524a0 )>"
)

Will attempt to recover by breaking constraint
<NSLayoutConstraint:0x600001778d20 CMAppLogo.height == 56 (active, names: CMAppLogo:0x7f8631f535c0 )>

Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKitCore/UIView.h> may also be helpful.
2019-04-11 21:37:26.613142+0200 CriticalMaps[2427:80984] [LayoutConstraints] Unable to simultaneously satisfy constraints.
Probably at least one of the constraints in the following list is one you don't want.
Try this:
(1) look at each constraint and try to figure out which you don't expect;
(2) find the code that added the unwanted constraint or constraints and fix it.
(
"<NSLayoutConstraint:0x600001732fd0 V:[UILabel:0x7f8671c72bc0'GPS']-(0)-| (active, names: '|':UITableViewCellContentView:0x7f8671c725a0 )>",
"<NSLayoutConstraint:0x600001733020 V:|-(0)-[UILabel:0x7f8671c72bc0'GPS'] (active, names: '|':UITableViewCellContentView:0x7f8671c725a0 )>",
"<NSLayoutConstraint:0x6000017328f0 UILabel:0x7f8671c72bc0'GPS'.height >= 56 (active)>",
"<NSLayoutConstraint:0x600001733b10 'UIView-Encapsulated-Layout-Height' UITableViewCellContentView:0x7f8671c725a0.height == 56 (active)>"
)

Will attempt to recover by breaking constraint
<NSLayoutConstraint:0x6000017328f0 UILabel:0x7f8671c72bc0'GPS'.height >= 56 (active)>

Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKitCore/UIView.h> may also be helpful.
2019-04-11 21:37:26.613667+0200 CriticalMaps[2427:80984] [LayoutConstraints] Unable to simultaneously satisfy constraints.
Probably at least one of the constraints in the following list is one you don't want.
Try this:
(1) look at each constraint and try to figure out which you don't expect;
(2) find the code that added the unwanted constraint or constraints and fix it.
(
"<NSLayoutConstraint:0x6000014d9cc0 UILabel:0x7f8671c8aa70'Website'.centerY == UITableViewCellContentView:0x7f8671c8a880.centerY (active)>",
"<NSLayoutConstraint:0x6000014db7f0 V:[UILabel:0x7f8671c8aa70'Website']-(0)-| (active, names: '|':UITableViewCellContentView:0x7f8671c8a880 )>",
"<NSLayoutConstraint:0x6000014d8e60 UILabel:0x7f8671c8aa70'Website'.height >= 56 (active)>",
"<NSLayoutConstraint:0x60000174d310 'UIView-Encapsulated-Layout-Height' UITableViewCellContentView:0x7f8671c8a880.height == 56 (active)>"
)

Will attempt to recover by breaking constraint
<NSLayoutConstraint:0x6000014d8e60 UILabel:0x7f8671c8aa70'Website'.height >= 56 (active)>

Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKitCore/UIView.h> may also be helpful.
2019-04-11 21:37:26.614103+0200 CriticalMaps[2427:80984] [LayoutConstraints] Unable to simultaneously satisfy constraints.
Probably at least one of the constraints in the following list is one you don't want.
Try this:
(1) look at each constraint and try to figure out which you don't expect;
(2) find the code that added the unwanted constraint or constraints and fix it.
(
"<NSLayoutConstraint:0x60000174d810 UILabel:0x7f8631c31920'Twitter'.centerY == UITableViewCellContentView:0x7f8631c31730.centerY (active)>",
"<NSLayoutConstraint:0x60000174d950 V:[UILabel:0x7f8631c31920'Twitter']-(0)-| (active, names: '|':UITableViewCellContentView:0x7f8631c31730 )>",
"<NSLayoutConstraint:0x60000174d7c0 UILabel:0x7f8631c31920'Twitter'.height >= 56 (active)>",
"<NSLayoutConstraint:0x60000174def0 'UIView-Encapsulated-Layout-Height' UITableViewCellContentView:0x7f8631c31730.height == 56 (active)>"
)

Will attempt to recover by breaking constraint
<NSLayoutConstraint:0x60000174d7c0 UILabel:0x7f8631c31920'Twitter'.height >= 56 (active)>

Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKitCore/UIView.h> may also be helpful.
2019-04-11 21:37:26.614450+0200 CriticalMaps[2427:80984] [LayoutConstraints] Unable to simultaneously satisfy constraints.
Probably at least one of the constraints in the following list is one you don't want.
Try this:
(1) look at each constraint and try to figure out which you don't expect;
(2) find the code that added the unwanted constraint or constraints and fix it.
(
"<NSLayoutConstraint:0x60000174e1c0 UILabel:0x7f8631c48e50'Facebook'.centerY == UITableViewCellContentView:0x7f8631c48c60.centerY (active)>",
"<NSLayoutConstraint:0x60000174e210 V:[UILabel:0x7f8631c48e50'Facebook']-(0)-| (active, names: '|':UITableViewCellContentView:0x7f8631c48c60 )>",
"<NSLayoutConstraint:0x60000174e0d0 UILabel:0x7f8631c48e50'Facebook'.height >= 56 (active)>",
"<NSLayoutConstraint:0x60000174e940 'UIView-Encapsulated-Layout-Height' UITableViewCellContentView:0x7f8631c48c60.height == 56 (active)>"
)

Will attempt to recover by breaking constraint
<NSLayoutConstraint:0x60000174e0d0 UILabel:0x7f8631c48e50'Facebook'.height >= 56 (active)>

Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKitCore/UIView.h> may also be helpful.

It would be nice to have a script to update all our dependencies such as

• bundle update and bundle exec
• fastlane snapshot update
• license-plist
• swiftformat

Open Questions/Tasks

• Verification (Signature?)
• Verification caching
• Maps UI
• Settings UI
• Storage
• documentation

Handle label slips under dateLabel

Add the Artwork, version and build number to settings.

Any other information to show here?