Git Product home page Git Product logo

Comments (5)

golanlevin avatar golanlevin commented on May 28, 2024

Lower right heart should look like this:

IMG_8688

from pembroider.

LingDong- avatar LingDong- commented on May 28, 2024

Fixed in : 666e576

Turns out the chunky looking parallel and concentric hatching is not due to the new resampling method. It is because we’re using the raster mode, which has a step. It goes a step, check if it is outside of the polygon, and go another step, etc. The step is automatically set to 1/4 of stitch length based on my random guess. In your image the stitch length is huge. I now set the step to 1 for all situations. Slow but works

BTW, image() also works for PImages directly, no need to render them to PGraphics first. However, since currently the image needs to be inverted, I kept the PGraphics in the example, so that I can use PG.filter(INVERT); Maybe we can add an option to toggle "inverted" mode for images?

Screen Shot 2020-06-13 at 2 38 26 AM

from pembroider.

golanlevin avatar golanlevin commented on May 28, 2024

OK. We still have the issue, that

When using CONCENTRIC hatch mode, the outer edge of the shape is not currently being stitched. This is visible in the middle embroidery on the lower row. The outside edge should not be omitted from the CONCENTRIC hatch.

Perhaps this can be a setting — something like, E.INCLUDE_STROKE_IN_CONCENTRIC_HATCH = true;

from pembroider.

LingDong- avatar LingDong- commented on May 28, 2024

@golanlevin

Now fixed: 43a5b32

It will automatically add a stroke if fill is concentric and no stroke has been specified.

from pembroider.

golanlevin avatar golanlevin commented on May 28, 2024

Thanks, @LingDong- . I'm not certain if SPIRAL mode also needs the same fix or not, but I'll close this for now.

from pembroider.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.