Comments (3)
Similarly, all extending types from TaskDescriptor
need to specify MeasuresSerializer
to be used for the measures
property.
@Serializable
data class IndefiniteTask(
override val name: String,
@Serializable( with = MeasuresSerializer::class )
override val measures: List<Measure> ) : TaskDescriptor()
from carp.core-kotlin.
I believe this is only needed for deserialization, thus this is less important for extending types in external libraries outside of our control (serialization will still work correctly).
Concretely, this thus only impacts 'server-side'. Each time we introduce 'default' supported tasks and measures, we need to remember to apply these attributes correctly. In case there is no way to reuse the serializer defined on the base type, we could consider implementing a runtime check which triggers an exception in case the attribute is not defined.
from carp.core-kotlin.
In Kotlin 1.3 the equivalent of this will become a Polymorph
attribute which needs to be applied for polymorph serialization to work.
Having looked more into this, I now believe this will most likely remain a requirement. The question then becomes, how can we enforce correct implementations of deriving types. We could check in a static initializers of such types whether the attribute is applied correctly, and throw a suitable runtime error in case it is not present.
from carp.core-kotlin.
Related Issues (20)
- Should `DataStreamService.openDataStreams` not fail for existing streams?
- Automatically bundle RPC example requests in releases
- Implement unit of work pattern for repositories HOT 1
- `PrimaryDeviceDeployment.lastUpdatedOn` is only accessible in Kotlin
- Can logged in `participantId` be modeled in client's `StudyStatus`?
- Storing `triggerId` and `deviceRoleName` in `TriggeredTask` is redundant HOT 2
- Should `DeviceRegistration` include freeform specification data? HOT 7
- `StudyStatus.Configuring.canGoLive` should check for more data HOT 6
- Can't find device with role name 'location_service' in snapshot. HOT 2
- Change invitations after study has gone live
- Use new JSON unquoted literal in `UnknownPolymorphicSerializer`
- TypeScript types passed between modules cause incompatible type warning requiring cast to `any` HOT 1
- Deserializing Measurement fails when using custom data types HOT 5
- TypeScript export for `Nullable` is missing HOT 7
- Need to know the version tag for a StudyProtocolSnapshot HOT 1
- Add phone number input data type HOT 3
- Redundant data type descriptors on data stream data points
- Add informed consent input data type HOT 1
- Add Social Security Number as Input Data Type HOT 4
- Inherited properties are missing from StudyProtocolSnapshot TS class
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from carp.core-kotlin.