Git Product home page Git Product logo

Comments (4)

Whathecode avatar Whathecode commented on July 22, 2024 1

If all you need is a string, you could just add it as a custom participant attribute to the protocol.

As we discussed in person, there may be a requirement to still have full control over the data type name. I will check whether the custom suffix and uuid are essential for things to work or not. I think it may just be API convenience, in which case it already should work now if you provide the right JSON payload.

from carp.core-kotlin.

Whathecode avatar Whathecode commented on July 22, 2024

The current constraints for participant data are managed upon protocol creation, and whenever the "expected participant data" is set. The logic for this lives in ExpectedParticipantData.kt:

Determines whether the set contains any of the following conflicts:

  • contains differing participant attributes with the same input data type
  • contains multiple attributes of the same input data type which are assigned to the same role

As long as the input data type is unique, there should thus be no problem. When you set the expected participant data, you have to pass the InputElement by using CustomParticipantAttribute instead of DefaultParticipantAttribute. Default denotes the input element and validation is known at compile time; "custom" implies it isn't and thus needs to be specified at runtime by the one configuring the protocol.

I see that there is no integration test covering this, and thus also no example JSON requests generated for this. I will add this to clarify usage.

In addition, the Kotlin API currently doesn't allow to specify the InputDataType for CustomParticipantAttribute; it generates a unique ID in the format of dk.cachet.carp.input.custom.9004a473ce624c49bcec34a238174118. This is by design to protect the dk.cachet.carp.input namespace, but maybe is overly strict. The main goal here is to not pollute dk.cachet.carp.input with types for which support may be added later on, which would cause conflicts when comparing/handling data. E.g., if you use dk.cachet.carp.ssn now, but support gets added at with a stricter/different format. I think a suitable compromise is to allow you to set your own InputDataType, but restricting access to dk.cachet.carp sub-namespaces. @bardram Would this serve your need?

from carp.core-kotlin.

Whathecode avatar Whathecode commented on July 22, 2024

I see that CAMS already uses the same namespace for data types.

That's something we overlooked, and ideally would have been a CAMS namespace. If core were to add any of these, backwards compatibility will break.

Maybe I should disallow custom types in carp namespaces, but provide an option to disable that constraint for backwards compatibility.

from carp.core-kotlin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.