Spacing should be divided by two

In the RADME, a link to the Mattermost team exists. However, it only displays a forms to connect to the team, and not to create a new account on it.

@victor-sarda @rozierguillaume How can developers join this place?

Currently the navigation can be improved for Voice Over users, mainly on search fields, buttons and search results.
In fact, hours or dates are not well vocalized.
Some items should be vocalized, and others should be not.
Providing Voice Over-ready UI improves navigation for disabled users.

Objectif : être cohérent avec la version web et éviter les ambiguïtés.

Add a Settings view, with a ⚙️ icon to open it next to the logo on the Home view.

This Settings screen should contain:

• Links: FAQ/VaccinTracker/...
• An additional link to open the contributors view (See #122)
• Options to contact us and/or report a bug
• UI Settings: app theme (system/light/dark) and accessibility

After #42, we can then easily replace occurrences of Centre by Lieu in the Localizable.strings file.

Linked to CovidTrackerFr/vitemadose-front#18 (follow what was done on frontend and android)

Add widgets, to:

• Show global stats
• Show next rendez-vous for a place (centre, city or department)
• Anything else?

Here is what the frontend provides in term of sorting options:

We can add a UISegmentedControl under Liste des centres and before the first cell to allow the user to choose how to sort the list.

We will add a new platform on back-end, can you please add the support for it?

"plateforme": "AvecMonDoc"

https://patient.avecmondoc.com/assets/images/fronts/logo-AMD.png

See https://twitter.com/flpichard/status/1385652302619586561?s=21

Why

We should list somewhere in the application the list of dependencies in use inside this iOS app.
Thus depending to the component, the project will be more compliant.
Moreover, listing dependencies is clear fo users and cool for developers behind these tools.

How

One tool can be used: [LicensePlist)(https://github.com/mono0926/LicensePlist).
It will dive in the Xcode project magic files, and produce a global file will all direct and indirect third-party components.
Then the output should be place in the Settings.bundle of the project.

First, according to the tool README, install in your local environment the tool:

brew install mono0926/license-plist/license-plist

Then run the tool:

license-plist

A folder with PLIST for each component will be generated (com.mono0926.LicensePlist), and also an index file (com.mono0926.LicensePlist.plist). These elements can be placed in the Settings.bundle folder.

A run script build phase can be added so as to update the items.

In addition, the tools we directly use in the project, i.e. referenced in our level through CocoaPods and Swift Package Manager can be listed in the repository.

Opening the URL directly here would allow to open the app of the website if installed.
Also, I thing it's way more comfortable to browse it in safari than in a view controller in the app.

See this conversation:

We are going tol add a new platform on back-end, can you please add the support for it?

"plateforme": "Clikodoc"

https://www.clikodoc.com/images/home/logo_header_v1.png

It could be a great improvement to replace storyboard files by programmatic user interface, mainly about performances.

Some files are very simple (like the home view which is a navigation controller containing a table view controller), and the loading of those storyboard files takes a lot of time compared of what it would be using programmatic user interface.

Write some tests and add a CI to check that everything builds for each commit and each PR.

We'll need to refactor the current API Service and/or use a library if needed.
The current one could benefit some improvements, especially around the error handling part.

A different way to handle the issue #76. Because it is preferable to stick with SFSafariWebView instead of opening Safari. Cc @nathanfallet.

UIApplication.shared.open(url, options: [.universalLinksOnly: true]) { (success) in
    if !success {
        // not a universal link or app not installed, opening in Safari Web View instead
        let safariViewController = SFSafariViewController(url: url, configuration: config) 
        safariViewController.present(vc, animated: true)
    }
}

Source: https://recoursive.com/2019/02/22/preflight_universal_links/

Without changing lots of code, performances (runtime, compilation), security and quality can be improved with an internal Swift package.
It can also helps to easily share code with potential extensions.

Discuss about it with backend team.

Ideas:

• Notifications for limited time for a certain place?
• One notification for all centers?

Anything else?

Should be pretty easy, all the localized ressources are already there.

Using app group (suiteName), you can share settings with extensions (Messages, Widget or anything else).

Take all the strings of the app, and put them together in a Localizable.strings file.

Then create an enum (or struct with constants) to use them.

struct LocalizedString {

  static let example = "example".localized()
  // ...

}

(This is an example where example is the string id in the Localizable.strings file)

So far only one crash was reported on Crashlytics and should be fixed in the next version.
It seems to be an issue with the home heading section reload. From what I see, conforming sections to Identifiable should fix it.

Fatal Exception: NSInternalInconsistencyException
Section identifier was not found. You can verify the section exists by calling the indexOfSectionIdentifier API (which has O(1) performance)
HomeViewController.reloadHeadingSection(with:)

Describe the bug
Currently on the app, "MeSoigner" logo doesn't appear because the asset name doesn't match the parsed value for plateforme. It also does not show up on the home page because the xib view is using the wrong name.

To Reproduce
Steps to reproduce the behavior:

1. Open the app and scroll to the partners logos section
2. Alternatively, open a list of centres where some are from MeSoigner

Expected behavior
Logo is displayed

Screenshots

Smartphone:

• Device: iPhone 11 Sim
• OS: 14.6
• App version 1.3.1 (dev)

Ideally the user should be able to quickly select the latest department they viewed.
This could easily be achieved by saving the latest selected department code in user defaults.

Mockup:

Description

Right now the home percentage cell doesn't check if the total amount of centres available is higher than 0. This can result into a crash (divide by zero)

Suggestion

    var pourcentage: Int? {
        // Prevent divide by zero crash
        guard total > 0 else {
            return nil
        }
        return (disponibles * 100) / total
    }

Percentage value would become optional so fallback text could be "-" (it should never happen)

Linked to #41

As the front implemented it, we need to be able to search a dose by City (more precise than by Department)

Useful links:

• https://github.com/CovidTrackerFr/vitemadose-front/blob/dev/src/views/vmd-rdv.view.ts
• https://github.com/CovidTrackerFr/vitemadose-front/blob/dev/src/state/State.ts

A bookmark/favorite system containing:

• a little star on vaccination centre cells to add to favorite
• a favorite tab or section to browse them later
• receive a push notification when the number of available doses changes from zero to non-zero

As a user, when I change my device accessibility setting to increase or lower the font sizes, I want to have the app font size changed, so that I can easily read the content of the app.

Apple will no longer allow apps compiled for iOS 13 starting next week, it is urgent to migrate to iOS 14!
iOS 13 will still be supported, but the app will be compiled for iOS 14.

Tapping on a centre address makes the app crash in iPad.
It's a simple fix: the action sheet needs a popoverPresentationController?.sourceView

Version: 1.0.0-beta

It's a simple fix: it needs to use the FR region like we do for the appointments hours

Write a test suite.

Not sure if it is the right place to tell you this but FYI the app language is set to English on the App Store product page.

Time is not correct when a center is from mapharma.

Example:

    {
      "departement": "49",
      "nom": "Pharmacie Des Halles",
      "url": "https://mapharma.net/49100-7?c=237&l=0",
      "location": {
        "longitude": -0.554808,
        "latitude": 47.47116,
        "city": "ANGERS"
      },
      "metadata": {
        "address": "78 RUE BAUDRIERE, 49100 ANGERS",
        "business_hours": null
      },
      "prochain_rdv": "2021-05-10T10:30:00",
      "plateforme": "Mapharma",
      "type": "drugstore",
      "appointment_count": 19,
      "internal_id": "mapharma2d373f633d323337266c3d3",
      "vaccine_type": [
        "AstraZeneca"
      ],
      "appointment_by_phone_only": false,
      "erreur": null,
      "last_scan_with_availabilities": "2021-05-08T17:17:29.605276+02:00",
      "appointment_schedules": {
        "1_days": 0,
        "2_days": 0,
        "7_days": 19,
        "28_days": 19,
        "49_days": 19
      },
      "gid": "2d373f633d323337266c3d3"
    }

Other source example:

    {
      "departement": "49",
      "nom": "Centre de vaccination Covid-19 - Ville de Saumur",
      "url": "https://www.doctolib.fr/centre-de-sante/saumur/centre-de-vaccination-covid-19-ville-de-saumur",
      "location": {
        "longitude": -0.094039,
        "latitude": 47.267295,
        "city": "Saumur"
      },
      "metadata": {
        "address": "Avenue du Breil, 49400 Saumur",
        "phone_number": "+33241831288",
        "business_hours": {
          "lundi": "08:30-12:00, 13:30-17:00",
          "mardi": "08:30-12:00, 13:30-17:00",
          "mercredi": "08:30-12:00, 13:30-17:00",
          "jeudi": "08:30-12:00, 13:30-17:00",
          "vendredi": "08:30-12:00, 13:30-17:00",
          "samedi": null,
          "dimanche": null
        }
      },
      "prochain_rdv": "2021-05-11T10:10:00.000+02:00",
      "plateforme": "Doctolib",
      "type": "vaccination-center",
      "appointment_count": 1129,
      "internal_id": "doctolib242320",
      "vaccine_type": [
        "Pfizer-BioNTech",
        "Moderna"
      ],
      "appointment_by_phone_only": false,
      "erreur": null,
      "last_scan_with_availabilities": "2021-05-08T17:17:29.613270+02:00",
      "appointment_schedules": {
        "7_days": 33,
        "28_days": 658,
        "49_days": 1129,
        "1_days": 0,
        "2_days": 0
      },
      "gid": "d242320"
    }

We need to add unit tests before releasing the next version.

ACs:

• Test ViewModels
• Test Models
• Test API calls

There is a know issue when using Firebase with SPM.
It makes the archive/upload process fail but there's a workaround that we already tested and seems to be working:

firebase/firebase-ios-sdk#6472

Update app name, description and keywords.

Needle should be white on the app icon

Describe the bug
When Voice Over is enabled, some numbers are not well vocalized: each digit is vocalized, but not the whole number.

To Reproduce

1. Enable Voice Over vocalization
2. Make a search, each for Toulouse
3. Select the result cell
4. Each digit of 91 014 is vocalized like 9 1 0 1 4

Expected behavior
The number must be vocalized like 91 014

Screenshots

Smartphone (please complete the following information):

• Device: iPhone
• OS: iOS 14.g. iOS 14]
• App version: 1.3.0

Additional context
Woops sorry, didn't find this bug!

Describe the bug
When the accessibilty feature is enabled, with very big text sizes, the "mes centres suivi" cell has not a bigger text.

To Reproduce
Steps to reproduce the behavior:

1. In device settings, enable accessibility option for bigger texts
2. Define text size as almost the highest, or more
3. Add a center as a favorite center (clock icon)
4. See the cell for the followed centers

Expected behavior
Text of the cell must have a bigger size.

Screenshots

Smartphone (please complete the following information):

• Device: iPhone
• OS: iOS 14
• App version: 1.3.0

Additional context
Woops sorry, didn't find this bug!

Mockup:

It was requested that we add a feature to display a maintenance page if needed (in case we ever have issues with servers / data). The page would show up based on a feature flag on Firebase Remote Config.

I started working on this already and will push changes this evening.

A simple table view that shows all contributors of VMD. A design similar to CountiesSelectionViewController.

Linked with CovidTrackerFr/vitemadose#228

For some reason the project scheme is missing on develop.
This needs to be fixed before merging more PRs!

A script to automatically set the build number was introduced in the last version but doesn’t seem to work right now.

Now that we have a separate project for dev on Firebase, we need to add it to our debug scheme to avoid sending debug crashes/analytics on prod