Git Product home page Git Product logo

Comments (4)

snej avatar snej commented on July 24, 2024

Crap, this happens every time I use strlcpy — it always ends up in some cross-platform code that someone tries to build on Linux ;-)

Maybe you could add a static implementation of strlcpy and #ifdef it appropriately for non-BSD platforms?

from cbforest.

jpetso avatar jpetso commented on July 24, 2024

I can probably do that. I wonder whether in this case, it would be easier to move the one-liner to the .cc file and add one or two lines of length checking, akin to http://stackoverflow.com/a/2115073. I'm not sure what you intend to happen if the string doesn't fit - right now, no error is returned and the string is just cut off (with zero termination due to strlcpy).

from cbforest.

jpetso avatar jpetso commented on July 24, 2024

I found that the other constructor is doing something very similar (and concise) already, so I adapted its code and used it for the const char* constructor. Added a commit to my pull request #6, this should be the last one to add. (I still need to make sqlite3-unicodesn build within my CMake build but in terms of code portability it's looking good now.)

from cbforest.

jpetso avatar jpetso commented on July 24, 2024

Fixed by commit eabd5ee.

from cbforest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.