C4Error: variables of struct is not initialized with 0 on Android platform about cbforest HOT 4 CLOSED

That commit isn't necessary. Clients of the C4 API do not have to initialize C4Error variables. The function you call will set the fields of the error if it fails.

The problem seems to be that there's a function that's failing without properly initializing the C4Error on the way out.

from cbforest.

In case of end of leaf, selectNextLeaf() returns false with C4Error.error = 0

That indicates there's no error. The JNI wrapper shouldn't treat it as an exception — that's the fix that needs to be made.

from cbforest.

Change the JNI function like this:

    if (ok || error.code == 0 || error.domain == HTTPDomain)  // 404 or 410 don't trigger exceptions

A 0 error code always indicates no error, no matter what the domain is.

from cbforest.

@snej, thank you for your input. I will change it.

from cbforest.