coteh / logistics Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 2.0 1.22 MB

:rose: :rocket: Rose Rocket Coding Challenge

HTML 1.35% TypeScript 97.57% SCSS 1.08%

frontend hacktoberfest react test-driven-development

logistics's Introduction

logistics's People

Contributors

Stargazers

Watchers

Forkers

nikijiandani grigori-gru

logistics's Issues

Split driver task validator method into two, one for input validation and one for conflict checking

You can see here:

logistics/src/domain/validator/DriverTaskValidator.ts

Lines 36 to 61 in 473ac56

 /** 

  * Validate a driver task 

  * @param args driver task information to be used for validation 

  * @remarks a future improvement to this validator would be to split this method into two, one for validation one for conflicts 

  * @returns result of driver task validation (ie. whether there's any validation errors or conflicts) 

  */ 

 public validateTaskEntry(args: DriverTaskArgs): DriverTaskValidationResult { 

 let userTasks: DriverTask[] = this.driverTaskRepo.getWeeklyTasksByUserID({ 

 userID: args.userID, 

 startWeek: args.week, 

 endWeek: args.week, 

 ignoreIDs: args.ignoreIDs, 

 }); 

 let conflictingTasks: DriverTask[] = userTasks.filter((task) => { 

 return ( 

 args.day === task.day && args.start < task.end && task.start < args.end 

 ); 

 }); 

 return { 

 conflict: conflictingTasks.length > 0, 

 invalid: args.start >= args.end, 

 conflictingTasks: 

 conflictingTasks.length > 0 ? conflictingTasks : undefined, 

 }; 

 }

that the "invalid" driver task check is just one small part of the function, and the rest of it checks for conflicting tasks. I think that this should be refactored so that there's one function that checks for validity of driver task and the other checks for whether driver tasks conflict with other tasks.

Update TSDoc comments and tests as well.

Add red colour for error notifications and light green colour for success notifications

Fix inability to schedule between 11:00PM to 12:00AM

Small oversight when originally designing the scheduling system. Add ability to schedule between discrete times of 11 PM to 12 AM, but without it going into the next day. This would likely require a new discrete time value be added (25 since original requirement for discrete time was 1-24 IIRC) and can only be selected when selecting end time.

Convert CSS modules to SCSS modules

Fix test warning

src/App.spec.tsx
  ● Console

    console.error
      Warning: An update to App inside a test was not wrapped in act(...).
      
      When testing, code that causes React state updates should be wrapped into act(...):
      
      act(() => {
        /* fire events that update state */
      });
      /* assert on the output */
      
      This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
          in App (at App.spec.tsx:7)

      79 |       .getWeeklyUserTasks(selectedUserID, selectedWeek, loggedInUser)
      80 |       .then((res: DriverTask[]) => {
    > 81 |         setTasks(res);
         |         ^
      82 |       })
      83 |       .catch((err: ServiceError) => {
      84 |         console.log(err.message);

      at printWarning (node_modules/react-dom/cjs/react-dom.development.js:88:30)
      at error (node_modules/react-dom/cjs/react-dom.development.js:60:5)
      at warnIfNotCurrentlyActingUpdatesInDEV (node_modules/react-dom/cjs/react-dom.development.js:23284:7)
      at setTasks (node_modules/react-dom/cjs/react-dom.development.js:15656:9)
      at src/App.tsx:81:9

Add explicit 'description' field to driver tasks

Add a "description" field for driver tasks, and add an input field for specifying description when adding or editing a driver task.

coteh / logistics Goto Github PK

logistics's Introduction

logistics's People

Contributors

Stargazers

Watchers

Forkers

logistics's Issues

Split driver task validator method into two, one for input validation and one for conflict checking

Add red colour for error notifications and light green colour for success notifications

Fix inability to schedule between 11:00PM to 12:00AM

Convert CSS modules to SCSS modules

Fix test warning

Add explicit 'description' field to driver tasks

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	/**
	* Validate a driver task
	* @param args driver task information to be used for validation
	* @remarks a future improvement to this validator would be to split this method into two, one for validation one for conflicts
	* @returns result of driver task validation (ie. whether there's any validation errors or conflicts)
	*/
	public validateTaskEntry(args: DriverTaskArgs): DriverTaskValidationResult {
	let userTasks: DriverTask[] = this.driverTaskRepo.getWeeklyTasksByUserID({
	userID: args.userID,
	startWeek: args.week,
	endWeek: args.week,
	ignoreIDs: args.ignoreIDs,
	});
	let conflictingTasks: DriverTask[] = userTasks.filter((task) => {
	return (
	args.day === task.day && args.start < task.end && task.start < args.end
	);
	});

	return {
	conflict: conflictingTasks.length > 0,
	invalid: args.start >= args.end,
	conflictingTasks:
	conflictingTasks.length > 0 ? conflictingTasks : undefined,
	};
	}