cosmoskey / psis Goto Github PK

Love this idea, I'm going to want to play with this myself.

When I look at the module though, I tend to think Invoke-PSIS should be broken into multiple commands: Get-PSWebService, Add-PSWebService, Remove-PSWebService, Start-PSWebService, and Stop-PSWebService. Invoke isn't appropriate in my opinion because it implies that you are invoking a command on the web service then and there, not just creating the web service listener (Add-) and starting it up (Start-). I would also have the Add-PSWebService command automatically start the web service as well, and I would rename the ProcessRequest parameter as simply ScriptBlock (to be consistent with many other commands that accept a script block), but having ProcessRequest as an alias for that parameter makes sense. And with that naming, I would call the module PSWebService.

One nice thing about this name is discovery. Intellisense in the more recent versions of PowerShell will pick up on the "Service" part of the name, so if you were to type Get-Serv you should see Get-PSWebService as one of the options. Ditto for Start-Serv/Stop-Serv, etc.

Note that I haven't thought this naming scheme through, this was just my knee-jerk reaction when I saw what you had published.

Kirk out.