Comments (10)
ebuchman
commented on September 23, 2024
1
The intention is to start testing this on testnets this summer (~late July/early August), and ideally for it to go live on the hub sometime in the fall.
from ledger-cosmos-go.
aaronc
commented on September 23, 2024
1
You can enable protobuf transactions in tests and simd with the test_proto flag. We're still fixing the remaining failing unit tests but most stuff works.
from ledger-cosmos-go.
jleni
commented on September 23, 2024
what is the timeframe/deadline of this? planned release date?
from ledger-cosmos-go.
jleni
commented on September 23, 2024
I will put it in my calendar, so we can catch up at the last week of July
from ledger-cosmos-go.
jleni
commented on September 23, 2024
@ebuchman @zmanian How are you progressing?
Are we at a point where i should start looking at this and check the code/specs on your side?
from ledger-cosmos-go.
webmaster128
commented on September 23, 2024
@zmanian can you adapt 0.39 -> 0.40 in the title of this ticket to avoid confusion? The now released Cosmos SDK 0.39 (Launchpad) does not change signing.
from ledger-cosmos-go.
ebuchman
commented on September 23, 2024
I believe full integration is still a work in progress (cc @alexanderbez @aaronc) but there is initial code for the protobuf based txs and unit tests. It would probably be helpful if you'd review the ADR-20 if you haven't yet which describes how this is going to look.
from ledger-cosmos-go.
zmanian
commented on September 23, 2024
We expect that the initial target for the Ledger app will be ensuring the SIGN_MODE_LEGACY_AMINO sign mode. Now that all the changes are merged into Cosmos SDK master we will be assessing any impactful changes to the Legacy Amino.
I'm unclear on whether or not we want to consider supporting SIGN_MODE_DIRECT in the Ledger. My initial instinct would be not support it.
Eventually we will want to support SIGN_MODE_TEXTUAL.
from ledger-cosmos-go.
zmanian
commented on September 23, 2024
We've audited the Legacy Amino JSON and expert mode works without any changes for generating signatures.
I'm expecting some changes to be needed to deal with the stabilized MsgTypes but the SignDoc is basically the same.
We will need to adopt the newer sign modes before the hub upgrades to 0.41.
See for more details.
cosmos/stargate-launch#8
from ledger-cosmos-go.
tac0turtle
commented on September 23, 2024
closing this for now since ledger works with 0.45. Once sign mode textual lands we would need to come back here
from ledger-cosmos-go.
Related Issues (19)
- version check is too strict for custom projects HOT 2
- Upgrade to latest ledger-go
- FindLedgerTendermintValidatorApp on error should unconditionally Close() the Ledger to avoid leaking
- FindLedgerCosmosUserApp could use a single defer and check on a named return err to close Ledger
- all: unnecessary use of fmt.Errorf for non-formatting errors, could instead use errors.New
- Upgrade from `go dep` to `go mod` HOT 1
- Tag new release or use upstream in sdk HOT 2
- depends on zondax/ledger-go HOT 2
- Refactor/rework release process HOT 1
- Rework fork relations HOT 1
- Cannot detect ledger on MacOS Ventura 13.6 or MacOs Sonoma HOT 13
- Unclear code due to unnecessary err value return in FindLedgerCosmosUserApp
- LedgerCosmos.CheckVersion error on unsupported version should display the Ledger major version for a better user experience HOT 1
- LedgerCosmos.GetBip32bytes has pedantic variables and non-idiomatic usages, unnecessary if err != nil, yet could just plainly invoke early returns HOT 1
- LedgerCosmos.getAddressPubKeySECP256K1 sends back wrong HRP length recommendation to user HOT 2
- LedgerCosmos.getAddressPubKeySECP256K1 could use string operations as they are for properly checking runes instead of bytes HOT 1
- Drop CGO HOT 1
- unknown option after '#pragma GCC diagnostic' kind [-Wpragmas] #pragma GCC diagnostic ignored "-Wstringop-overflow" HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ledger-cosmos-go.