corriander / python-sigfig Goto Github PK

There's a rounding ghost here. I haven't looked into exactly why this is rounding up with a following 5 but it's inconsistent with the behaviour of string() etc.

Not that truncating like this is a great idea anyway. I'm not sure I care enough to resolve this but it's worth pointing out.

There are a few formatting errors (namely in partially emphasised numbers).

Not really necessary but just for posterity.

round_() could be written more concisely:
http://stackoverflow.com/a/3411435/2921610

general form could be emulated more closely with an optional range modifier (e.g. 'e' format for e < -2 rather than -4).

Comma separated values should be available in string() really if large numbers are to be employed.

All this is is probably niche use though so maybe.