References to TAN Hotline in footer about cwa-event-landingpage HOT 9 CLOSED

@Ein-Tim Thanks for the suggestion, we will discuss this internally, Internal Tracking ID: EXPOSUREAPP-14643. Makes sense.

from cwa-event-landingpage.

@dsarkar & @MikeMcC399

What would you think about a PR removing the dates from both this repositories code & cwa-websites code? I'd also adjust the relevant tests so that they don't fail.

from cwa-event-landingpage.

@Ein-Tim

What would you think about a PR removing the dates from both this repositories code & cwa-websites code? I'd also adjust the relevant tests so that they don't fail.

Where are you seeing dates in this repository (https://github.com/corona-warn-app/cwa-event-landingpage)? There hasn't been any commit here since last year.

Regarding the cwa-website, I suggest to carry out the discussion in that repository. I don't see any urgency however as the presence of the date and the planned recorded message ensure that users are fully informed.

from cwa-event-landingpage.

@MikeMcC399

Sorry for not being clear. I meant to propose the following:

• remove hotline information from the footer of the websites which code is hosted in this repository
• remove hotline information (& the newly added shutdown date) from the website https://coronawarn.app

As @dsarkar already opened an internal ticket for this suggestion, I will leave the issue here and not follow-up in the cwa-website repository, as information from the JIRA ticket will be provided to this GitHub issue. If there is further, cwa-website specific discussion needed, we can continue in a separate issue there.

from cwa-event-landingpage.

@Ein-Tim Thanks again for bringing our attention to this issue. Indeed, the hotline telephone numbers should be removed in the footer. Do you want to provide a pull request?

from cwa-event-landingpage.

@dsarkar

For sure! PRs follow later today!

from cwa-event-landingpage.

@Ein-Tim Thanks, very much appreciated. I understand you will look also into the cypress test or you'd prefer if we do this?

from cwa-event-landingpage.

@dsarkar

I will look into it, but can't guarantee that I will be able to keep them working correctly. But as far as I see, it's only this test: https://github.com/corona-warn-app/cwa-website/blob/master/cypress/e2e/hotline.cy.js that needs changing.

from cwa-event-landingpage.

Hey there @dsarkar,

I provided two PRs:

• #67 for this repository
• corona-warn-app/cwa-website#3356 for the cwa-website repository

I also adapted the cypress tests myself!

from cwa-event-landingpage.