Missing social media links for landing pages about cwa-event-landingpage HOT 19 CLOSED

I will trigger the normal deployment process

from cwa-event-landingpage.

@MikeMcC399 Thanks for pointing this out.

from cwa-event-landingpage.

@Ein-Tim

I was not planning to provide a PR because first the issue about how this repository gets deployed needs to be solved. See your issue #32.

Unless this other issue is solved no change here in the repository would cause a change to the website.

from cwa-event-landingpage.

@MikeMcC399

You're right, I forgot!

Enjoy the weekend!

from cwa-event-landingpage.

I have a feature branch right now for testing it on all (4) ENVs but in the end deployment will be done from the main branch, sure.

from cwa-event-landingpage.

@Ein-Tim / @MikeMcC399
I'm just trying to figure out, who's responsible for this topic. Seems to be someone from SAP, @thomasaugsten ?

from cwa-event-landingpage.

@genericmueller We can provide and merge PRs. Concerning the social media in the footer, we will try by tomorrow to have a PR ready. Anything else needs to be done?

from cwa-event-landingpage.

@genericmueller I did add the footer changes to the main branch. Are you able to build the docker image and push it to the container registry or do you need someone to take care of it?

from cwa-event-landingpage.

@svengabr Theoretically, I can also build the image, but it is the responsibility of my colleagues. It must first be checked and approved. The image is built through their build pipeline and is then pushed to the registry. After that, a deployment has to be planned and our environments have to go through to production :) Unfortunately, this is the normal way even with these minor adjustments. However, I will inform the colleagues that the image can be rebuilt and tested.

from cwa-event-landingpage.

Noting the comment from @thomasaugsten in #32 (comment) "Deployment is done" the social media links on the footers of:

• https://e.coronawarn.app/ relating to the Event Landing Page
• https://s.coronawarn.app/ relating to the Rapid Antigen Test Landing Page

are now updated and showing as follows:

So, now closing this issue as resolved.

from cwa-event-landingpage.

@MikeMcC399

Do you plan to provide a PR for this? Else I could do it 🙂

from cwa-event-landingpage.

@dsarkar

What are the thoughts about making this change?

I believe that the website is only displayed if the user doesn't have the app installed, so probably it will not be seen often.

It would however be more consistent to use the same footer as on the main website.

from cwa-event-landingpage.

FYI: I just opened a CR for that and will bring it in production soon.

from cwa-event-landingpage.

@genericmueller

Thank you! So you will deploy the main branch, or?

from cwa-event-landingpage.

@Ein-Tim Hmm, I think I mixed something up here. Sorry. I have an internal branch for our deployment, but not in this repo. This repo here is only used to be part of a Docker image, which will then be deployed by us... But for now, the latest Image represents only the footer year changes as far as I see, not more... So someone needs to accept here the latest PRs and based on that create a new Docker image. Only then am I able to apply them to the Cluster.

from cwa-event-landingpage.

@genericmueller Right, currently this issue from @MikeMcC399 was not addressed with a PR. Currently the last merged PR is #33 (updating the copyright year).

So what needs to be done is:

1. Create a PR addressing this issue (@MikeMcC399 will you do this?)
2. Create a new Docker Image
3. You deploy the changes

FYI @dsarkar

from cwa-event-landingpage.

@genericmueller / @Ein-Tim

I suggest to look at PR corona-warn-app/cwa-website#2284 from cwa-website and pick the changes which apply here. @brifemu was the author.

I wasn't planning to submit a PR myself for this.

from cwa-event-landingpage.

@dsarkar Thank you! Sounds good. We can take over after the new docker image is pushed into our registry (MTR)...

from cwa-event-landingpage.

@svengabr
I suggest to re-open this issue until the changes are deployed.

from cwa-event-landingpage.