Before I realized that I can add new contacts with Net::Fritz::Phonebook->add_entry, I tried to use Net::Fritz::PhonebookEntry->save, which failed.

The latter method uses the action AddPhonebookEntry, which neither exists in AVM's x_contactSCPD.pdf document nor is supported by my Fritz!Box. I can save contacts if I replace AddPhonebookEntry with SetPhonebookEntry plus XML payload.

There's also a Net::Fritz::PhonebookEntry->create method, which uses AddPhonebookEntry. As far as I can see, that method cannot work. AddPhonebookEntry does not exist and SetPhonebookEntry requires at least a name.

There’s no EXE_FILES section in your Makefile.PL so the user has to dig the scripts out of the tarball separately… is that intentional? (And if so… can I request making a separate App:: out of them maybe?)

To get non-ASCII characters inserted correctly, I needed to add an explicit XML declaration to the XML passed to the SetPhonebookEntry service. This can be obtained by adding XMLDecl => 1 to the XMLout call.

sub add_entry( $self, $entry ) {
    my $s = $entry->build_structure;

    my $xml = XMLout({ contact => [$s]}, XMLDecl => 1);
    #use Data::Dumper;
    #$Data::Dumper::Useqq = 1;
#    $xml =~ s; (quickdial|prio|vanity)="";;g;
#    $xml =~ s;<category>0</category>;<category/>;g;
    #print Dumper \$xml;

    my $res = $self->service->call('SetPhonebookEntry',
        NewPhonebookID => $self->id,
        NewPhonebookEntryID => '', # new entry
        NewPhonebookEntryData => $xml,
    );
};

Alternatively, insert the header explicitly:

    $xml = '<?xml version="1.0" encoding="utf-8"?>'."\n".$xml;

(This is what I prefer, since it includes the encoding.)
You may wish to add the two lines stripping quickdial, prio and vanity attributes from phone numbers and eliminating the setting of category 0.

The following snippet:

my $entry = $phonebooks[0]->get_entry_by_uniqueid(1201);
printf( "%4d: %4d %s %s %s\n",
    $entry->uniqueid,
    $entry->phonebookIndex,
    $entry->category,
    $entry->name,
    join(",", map { $_->content } @{$entry->numbers}),
  );
$entry->delete;

This prints the data for entry with uniqueId 1201. In my particular case, this entry has phonebookIndex 26. After the delete is executed, entry with uniqueId 1201 still exists in the phonebook, but an unrelated entry (uniqueId 1101, phonebookIndex 31) is deleted instead.

The reason seems to be that, when retrieving all entries, or using get_entry_by_uniqueid, internal entries (e.g. **601) are included in the list (and occupy index numbers) while get_entry_by_index (and delete !) do not take these internal entries into account.

Ironically, when get_entry_by_index is used, the PhonebookEntry retrieved does not have its phonebookIndex set and hence it cannot be deleted unless you set the index manually.

And yes, entry index numbers are updated after each delete.

The XML to add a phone number uses the following number entity:

<number prio="" vanity="" quickdial="">123456</number>

The empty vanity and quickdial attributes lead to dummy quickdial/vanity codes in the primary phone book. To avoid this, remove them from the XML, e.g.

sub add_entry( $self, $entry ) {
    my $s = $entry->build_structure;

    my $xml = XMLout({ contact => [$s] }, XMLDecl => 1 );
    #use Data::Dumper;
    #$Data::Dumper::Useqq = 1;
    $xml =~ s; (quickdial|prio|vanity)="";;g;
    $xml =~ s;<category>0</category>;<category/>;g;
#    use DDumper; DDumper \$xml;
    #print Dumper \$xml;

    my $res = $self->service->call('SetPhonebookEntry',
        NewPhonebookID => $self->id,
        NewPhonebookEntryID => '', # new entry
        NewPhonebookEntryData => $xml,
    );
};