cordea / oauth Goto Github PK

View Code? Open in Web Editor NEW

65.0 8.0 9.0 198 KB

OAuth library for nim

License: Apache License 2.0

Nim 100.00%

nim oauth

oauth's Introduction

oauth

OAuth library for nim.

OAuth is composed of two modules. Please read documentation for details.

Install

nimble install oauth

Support version

Responding to version of nim is as below.

nim version	oauth version
>= v0.19.*	v0.10
>= v0.18.*	v0.6
>= v0.15.*	v0.5
v0.14.*	v0.3
v0.13.*	v0.2

License

Copyright 2016-2018 Yoshihiro Tanaka

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

oauth's People

Contributors

Stargazers

Watchers

Forkers

refaqtor dom96 permil shinriyo timotheecour demianfe inv2004 shampee thomastjdev

oauth's Issues

some deprecated methods in oauth2

I run nim c -d:ssl -r gitlab.nim in example folder.

oauth2.nim has some deprecated methods.

/Users/shinriyo/.nimble/pkgs/oauth-0.5/oauth2.nim(116, 40) Warning: use HttpPost instead; httpPost is deprecated [Deprecated]
/Users/shinriyo/.nimble/pkgs/oauth-0.5/oauth2.nim(116, 14) Warning: request is deprecated [Deprecated]
/Users/shinriyo/.nimble/pkgs/oauth-0.5/oauth2.nim(239, 60) Warning: use HttpGet instead; httpGet is deprecated [Deprecated]
/Users/shinriyo/.nimble/pkgs/oauth-0.5/oauth2.nim(242, 14) Warning: request is deprecated [Deprecated]

request is deprecated

/Users/shinriyo/.nimble/pkgs/oauth-0.5/oauth1.nim(217, 14) Warning: request is deprecated [Deprecated]

https://nim-lang.org/docs/httpclient.html#ssl-tls-support
Deprecated since version 0.15.0: use HttpClient.request instead.

Confusion with regards to the examples

I've just had the pleasure to use this wonderful library, and I have some questions regarding the examples.

The examples are awesome but they all seem to use authorizationCodeGrant, which launches a kind of hacky http server (why not use asynchttpserver? also, you should never use waitFor in an async proc!). Is this a common thing to offer to users of an oauth library?

I'm writing my own web app using Jester so I want to cover the callback part myself. I believe I can use getAuthorizationCodeGrantUrl myself but it would be nice to see the examples do this too.

Error: redirect_uri_mismatch

followed the url after "Please go to this url."
The redirect URI in the request, http://localhost:8080, does not match the ones authorized for the OAuth client. To update the authorized redirect URIs, visit: https://console.developers.google.com/apis/credentials/oauthclient/114704182264908205920?project=777725626149

CI is falling with latest develop branch of Nim

It is a problem of dependent library. I planning to resolve after the release of v0.17.3 because there is a possibility that this broken changes will change in the future.

Also I consider change a badge on README. (to latest release?)

Encoding URL base string on MediaWiki

When using the library on MediaWiki with this URL https://en.wikipedia.org/w/index.php?title=Special:OAuth/identify the signature does not work it returns "Invalid signature". The Nim library generates a signature string that ends with "title%3DSpecial%3AOAuth%2Fidentify" .. however to get it to work on MediaWiki the signature should end as "title%3DSpecial%253AOAuth%252Fidentify" which is to say the ":" and "/" in the query portion are urlencoded twice (":" -> "%3A" -> "%253A"). I don't know why this is, but it works. I don't know if this is OAuth specifications, a bug in MediaWiki or a bug in the Nim oauth library. It was a hard bug to discover so want to report it in case anyone else uses the library with MediaWiki.