copex / copex_vatfix Goto Github PK

Hi from Luca
But the module si enable only back end ?
I installed it but i verify that module is not active on frontend. it's correct ?

We use Magento 2.3.0

di.xml is starting with: <config>

this should be:
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">

While testing this extension it came to my attention that it is possible to input any valid VAT id, even a VAT ID from a totally different country. At least in The Netherlands that is against the customs regulations.

Here in The Netherlands we can deliver excl. VAT when:

1. The products are exported (so the shipping address has to be outside The Netherlands) to another EU country
2. The customer is a business with a valid VAT ID in the country where the goods are shipped to.

This information can be read on the following page:
http://www.belastingdienst.nl/wps/wcm/connect/bldcontentnl/belastingdienst/zakelijk/internationaal/btw_voor_buitenlandse_ondernemers/goederen/exporteren_vanuit_nederland_naar_andere_eu_landen/

Your extension allows to add any countrycode in front of the VAT ID, but the side effect of this is that anyone can input any VAT ID, not necessarily in the country which is specified in the address.

Is this intentional?

I would like to see this extension to strip the country-code or disallow countrycodes belonging to other countries.

Installed module, registered new account and this error occured.

We have a Magento 2.4.3-p1 installation running under php 7.4.27, VatFix installed via composer. The module is installed and active but does not produce any output in the debug. Are there any known compatibility issues with Magento 2.4.3?

The following error gets reported upon saving with a valid VatID:

PHP message: PHP Fatal error:  Call to undefined method CopeX\VATFix\Helper\Data::getCountryCodeFromVAT() in /var/www/magento2/vendor/copex/vatfix/Plugin/UidPlugin.php on line 45

It seems the getCountryCodeFromVAT is missing from the helper.

When I copy the files into folder app/code/CopeX/VATFix and run bin/magento setup:di:compile it stops compiling at 14% and says: [ErrorException] Uninitialized string offset: 1

Travis is failing to run unit tests, because the class PHPUnit_Framework_TestCase is missing. The reason for this again is that you are using the latest version of Magento (version 2.2) to run PHPUnit but this is version 6 (?) while Magento 2.1 ships with PHPUnit version 4 and which is required for the tests. I'm working on a simple PR to copy the code from 2.1, instead of the latest GitHub source.

Hi

If new user reach to checkout where user doen't have any addresss assigned yet, the code fails in checkout.
If it cannot verify the code and add error message
if (!empty($vatNumber) && !is_numeric($countryCodeFromVAT) && $countryCode != $countryCodeFromVAT) {
$this->addErrorMessage(__('Your selected country does not match the countrycode in VAT.'));
return [];
}

error message not visible and function return empty array
return [];

which causing parent function Magento\Customer\Model\Vat::checkVatNumber(), to fail

Fatal error: Uncaught ArgumentCountError: Too few arguments to function Magento\Customer\Model\Vat::checkVatNumber(), 0 passed in htdocs/vendor/magento/framework/Interception/Interceptor.php on line 58
and at least 2 expected in htdocs/vendor/magento/module-customer/Model/Vat.php:162 Stack trace: #0 htdocs/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Customer\Model\Vat->checkVatNumber()
#1 htdocs/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Customer\Model\Vat\Interceptor->___callParent('checkVatNumber', Array)
#2 htdocs/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Customer\Model\Vat\Interceptor->Magento\Framework\Interception{closure}('EE', 'FI12345678', 'EE', '12345678')
#3 /data01/virt71753/domeenid/www.multon. in htdocs/vendor/magento/module-customer/Model/Vat.php on line 162
{"messages":{"error":[{"code":500,"message":"Server internal error. See details in report api/922857370192"}]}}