coolcat-creations / ccc-mountain Goto Github PK

Here: https://github.com/coolcat-creations/ccc-mountain/blob/master/ccc-mountain/scss/template/_responsive.scss

Breakpoints are defined in the BS variables file, so you should used a media query like so:

@include media-breakpoint-down(md) { ... }
@include media-breakpoint-up(md) { ... }

etc..

https://github.com/coolcat-creations/ccc-mountain/blob/master/ccc-mountain/error.php#L137-L138

and:

https://github.com/coolcat-creations/ccc-mountain/blob/master/ccc-mountain/offline.php#L27-L28

another language string missing:
(when clicking on detect browser)
PLG_SYSTEM_ENVIRONMENTDETECT_DETECTED_PLATFORM_AND_BROWSER

in english it is:
We've redirected you to the right page for 'Mac OS / OS X' and 'Google Chrome'.

in Dutch this would be:
U bent verwezen naar de juiste pagina voor ... (OS)

hi,
maybe it is on purpose, but template.css is missing in the distrib.

A slash is missing too on line 26:
$tplpath = $this->baseurl . 'templates/' . $this->template;
should be:
$tplpath = $this->baseurl . '/templates/' . $this->template;

https://github.com/coolcat-creations/ccc-mountain/blob/master/ccc-mountain/error.php#L18-L27

I'm not sure exactly how you're compiling the SCSS, but if you're using something like Grunt (same as J4), then I'd siggest including those files in the repo so other can contribute :)

At https://browsercache-legen.nl/ on the English language I click on "Detect my Browser", then on my Linux machine with Chrome/Firefox appears the following message:
"Sorry we have no descriptions for your operating system"

When I use the Dutch or French language, the language string is not translated and
PLG_SYSTEM_ENVIRONMENTDETECT_CANT_DETECT_SYSTEM
appears instead.

BS4 only supports IE10 and above, so I'd suggest removing the following:

https://github.com/coolcat-creations/ccc-mountain/blob/master/ccc-mountain/offline.php#L32