coolbeet / cbstorehouserefreshcontrol Goto Github PK

in CBStoreHouseRefreshControl.m

line32:@Property (nonatomic, strong) UIScrollView *scrollView;

line82:refreshControl.scrollView = scrollView;

line87:[scrollView addSubview:refreshControl];

cause retain cycle
I think it should be:
line32:@Property (nonatomic, weak) UIScrollView *scrollView;

prefer to observe scrollview contentOffset

Is it possible to add to plist UIBezierPath like this?
[bezierPath addCurveToPoint: CGPointMake(83, 18) controlPoint1: CGPointMake(117, 33.22) controlPoint2: CGPointMake(101.78, 18)];

If not it would be a nice to have feature :)

Amazing work!!!
Is it possible to implement this as a UIRefreshControl for a UIWebView without the use of any UIScrollView or a subset? If not exactly this, would you know of something else with similar functionality and visuals that can be used as a UIRefreshControl for a UIWebView?

any easy way to write text,
i try paint code , but ididnt know how to get the text position of it,
any help
thanks

When I'm using your animated refresh object in the MasterViewController of an split view controller it is only centered in the complete screen, but not in the seperate part for the MasterViewController on the left.

CBStoreHouseRefreshControl support add to Footer?
Please any idea.

Hi, thanks for sharing :)

how do you make points for text? I mean text has spaces, should I use more then one start/end point?
one for each letter?

There're scenarios where you really need to know if the refresh control is currently refreshing. Thus, making 'state' a public property or even adding a new property (e.g. isRefreshing) would be useful.

@coolbeet

Jack

Hey, I got an error when i make [self.storeHouseRefreshControl finishedLoading], but i got no error when change finishedLoading to finishingLoading. Why I got this error?

In this way, we needn't write it one point by one point.

In line 114, the function ignores the color parameter, with a hardcoded [UIColor whiteColor].

when i set the UITableViewController's navigationBar.translucent to no,the refresh logo doesn't work fine

The loading view is interactive and good. Please provide the swift version so that it is compatible for it.

In the initializator method - attachToScrollView the color is being passed as a param but later it is not used.

Instead a white color is harcoded:

BarItem *barItem = [[BarItem alloc] initWithFrame:refreshControl.frame startPoint:startPoint endPoint:endPoint color:[UIColor whiteColor] lineWidth:lineWidth];

while this should be:

BarItem *barItem = [[BarItem alloc] initWithFrame:refreshControl.frame startPoint:startPoint endPoint:endPoint color:color lineWidth:lineWidth];

Im trying to change the color:

self.storeHouseRefreshControl = [CBStoreHouseRefreshControl attachToScrollView:self.tableView target:self refreshAction:@selector(refreshTriggered:) plist:@"storehouse" color:[UIColor blackColor] lineWidth:1.5 dropHeight:80 scale:1 horizontalRandomness:150 reverseLoadingAnimation:YES internalAnimationFactor:0.5];

When I change the color nothing happens. Is this possible?

Hello,

After triying this, it seems that it does not support when the navigation controller it set to hidden. Would love to try this but only will work form me if you could add this feature.

(void)viewWillAppear:(BOOL)animated
{
    [super viewWillAppear:YES];    
    [self.navigationController setNavigationBarHidden:YES animated:YES];
}

both pullup and pulldown

I used pod to get this refrehcontrol, however when i ask the function

    self.storeHouseRefreshControl = [CBStoreHouseRefreshControl attachToScrollView:self.waterfallView
                                                                            target:self
                                                                     refreshAction:@selector(pullToRefreshTriggered:)
                                                                             plist:@"storehouse"
                                                                             color:[UIColor redColor]
                                                                         lineWidth:1
                                                                        dropHeight:70
                                                                             scale:1
                                                              horizontalRandomness:150
                                                           reverseLoadingAnimation:YES
                                                           internalAnimationFactor:0.1];

the bar color is still in white, which makes me confuse.
after half an hour's debug i decided to look for source code and then i found that in the file CBStoreHouseRefreshControl.m, line 114, the color which i ask was not set properly, but used [UIColor whitecolor] instead!

I hope you can revise this one and, besides that, better remove all the warning :D

In my project, the tableView's inset is supposed to be zero, but on line 128

    if (self.originalTopContentInset == 0) self.originalTopContentInset = self.scrollView.contentInset.top; 

don't let it be zero, setting originalTopContentInset to dropHeight value, moving the tableView down:

can you please add a pod version for it

After the animation is complete, the scrollView (in my case UITableView specifically) is remaining offset by about the height of the storeHouse image...
Anyone else having this issue?
Followed demo to the letter.
This is probably the coolest iOS accessory I've seen in ages and would be upset if I couldn't make use of it!!!