convos-chat / linkembedder Goto Github PK
View Code? Open in Web Editor NEWEmbed / expand oEmbed resources and other URL / links
Embed / expand oEmbed resources and other URL / links
The test suite started to fail on my smoker systems:
# Failed test '400 Bad Request'
# at t/serve.t line 25.
# got: '404'
# expected: '400'
# Failed test 'content is similar'
# at t/serve.t line 25.
# '<!DOCTYPE html>
# <!-- Request ID: jCXyAk9vwlpw -->
# <html>
# <head>
# <title>Page Not Found (development mode)</title>
# <meta http-equiv="Pragma" content="no-cache">
...
# </footer>
# </body>
# </html>
# '
# doesn't match '(?^u:^cb\(\{.*"title":"example page".*\}\)$)'
# Looks like you failed 10 tests of 28.
t/serve.t ..............
Dubious, test returned 10 (wstat 2560, 0xa00)
Failed 10/28 subtests
This seems to happen with Mojolicious 9.11+. Here's the statistical analysis:
****************************************************************
Regression 'mod:Mojolicious'
****************************************************************
Name Theta StdErr T-stat
[0='const'] 1.0000 0.0000 10754762396631854.00
[1='eq_8.12'] 0.0000 0.0000 0.49
[2='eq_8.17'] 0.0000 0.0000 1.06
[3='eq_8.40'] 0.0000 0.0000 1.48
[4='eq_8.41'] 0.0000 0.0000 0.97
[5='eq_8.43'] 0.0000 0.0000 1.48
[6='eq_8.58'] 0.0000 0.0000 1.06
[7='eq_8.65'] 0.0000 0.0000 0.00
[8='eq_8.67'] -0.0000 0.0000 -0.28
[9='eq_8.68'] 0.0000 0.0000 0.42
[10='eq_8.69'] 0.0000 0.0000 0.97
[11='eq_8.70'] 0.0000 0.0000 2.23
[12='eq_8.71'] 0.0000 0.0000 0.28
[13='eq_8.72'] 0.0000 0.0000 1.18
[14='eq_9.11'] -1.0000 0.0000 -9619351920290954.00
[15='eq_9.12'] -1.0000 0.0000 -8781226725539987.00
[16='eq_9.13'] -1.0000 0.0000 -10495573407417170.00
R^2= 1.000, N= 125, K= 17
****************************************************************
https://home.thorsen.pm/demo/link-embedder -- the demo doesn't seems to work, just says "fetching".
Example: https://paste.debian.net/1186554
https://appear.in/link-embedder-demo
http://paste.scsys.co.uk/557716
Also, imgur.com
links don't open for me, but the image URL is correct, so maybe it's hotlinking to localhost that's being blocked..
Example:
Example URL: https://perlbot.pl/p/ggqqik
https://www.youtube.com/ links works, while https://youtu.be does not. Example: https://youtu.be/v4Ijkq6Myfc
In Convos sharing link to youtube returns an iframe with hardcoded height and width, is this configurable in this module as a parameter? some users find the video thumbnails to be too big.
See subject.
There's also a ticket on RT about failing the test suite with older Mojolicious versions: https://rt.cpan.org/Ticket/Display.html?id=120901
Example: https://twitter.com/convosby/status/1280032587931463680
See how good it can get without platform.twitter.com/widgets.js
It seems that LinkEmbedder-1.18 needs to increase its Mojolicious version. It fails for Mojolicious versions < 9.11. Statistical analysis:
****************************************************************
Regression 'mod:Mojolicious'
****************************************************************
Name Theta StdErr T-stat
[0='const'] -0.0000 0.0000 -12.63
[1='eq_8.26'] 0.0000 0.0000 0.00
[2='eq_8.40'] 0.0000 0.0000 0.00
[3='eq_8.41'] 0.0000 0.0000 13.31
[4='eq_8.43'] 0.0000 0.0000 2.10
[5='eq_9.01'] 0.0000 0.0000 10.52
[6='eq_9.03'] 0.0000 0.0000 4.21
[7='eq_9.11'] 1.0000 0.0000 57321465052731984.00
[8='eq_9.12'] 1.0000 0.0000 47958578471990840.00
[9='eq_9.13'] 1.0000 0.0000 72300277395640688.00
[10='eq_9.14'] 1.0000 0.0000 72066673303892016.00
R^2= 1.000, N= 74, K= 11
****************************************************************
A user told me that they have a home-rolled pastebin that they use that doesn't get embedded. While we can't expect to support every little bin, I think the situation as it exists could be somewhat improved.
The fallback in basic for generic pastetbins uses oddly-specific selectors, which I'm assuming conform to some specific paste sites. Notably the fact that it uses direct descendent selectors body > pre
and body > div > pre
is somewhat limiting. However in the specific case I'm looking at it wouldn't be insurmountable.
The site would work with a selector body > div > pre > code
. That selector is again rather specific, it would be odd to require a div tag like that, it could be body pre > code
to be a bit more accepting, though it would have to be attempted before body > div > pre
or it would never get there. Alternatively it could optionally look for a code
tag inside the resulting selector and walk into it if present. Or it could use all_text
rather than text
to get the tag contents. Are any of these suggestions acceptable?
in Convos sharing link https://google.com/search?q=marlin+lineageos+xda with link embedding ticked results in error message 'could not connect to google.com', I think this is a bug in the linkembedder module?
Not much information is shown when linking to https://hub.docker.com/r/convos/convos
Example: https://imgur.com/a/9elpnEV
See subject. Test log:
Can't locate Carp/Always.pm in @INC (you may need to install the Carp::Always module) (@INC contains: ... .) at t/link.t line 5.
BEGIN failed--compilation aborted at t/link.t line 5.
t/link.t ...............
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.