convex-eth / platform Goto Github PK
View Code? Open in Web Editor NEWConvex Smart Contract Platform
License: MIT License
Convex Smart Contract Platform
License: MIT License
The following function has no restriction on who can call it and thus someone could highjack the contract:
I am doing some tests regarding gas usage when the pools are drained and without log filtering it is very hard to know which TX drained which pool.
The morpho
address is logged in the transfer ownership event instead of morpho.owner()
:
Consider logging morpho.owner()
instead.
marketParams
is not validated in the following function:
And then a position is created on Morpho for this specific market:
This allows users to mint ConvexStakingWrapperMorpho
tokens without supplying the correct market.
Make sure that marketParams
is related to the correct morphoId
.
The current interface is the following:
platform/contracts/contracts/wrappers/ConvexStakingWrapperMorpho.sol
Lines 118 to 120 in c8c14b0
while the correct interface is:
Consider complying to the correct interface, else, the call via our bundler contract won't work.
The following functions are useless since AFAIK the ERC20Wrapper
interface will be used:
platform/contracts/contracts/wrappers/ConvexStakingWrapperMorpho.sol
Lines 78 to 81 in c8c14b0
platform/contracts/contracts/wrappers/ConvexStakingWrapperMorpho.sol
Lines 112 to 115 in c8c14b0
On transfer from user != (morpho || address(this))
nothing is done. Hence, use can directly supplyCollateral
on Morpho Blue and create position with an arbitrary number of collateral tokens.
Revert on transfer.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.