contributte / middlewares Goto Github PK

• Don't write into response message of exception
• Accept PSR-3 compatible logger to log that exception

@f3l1x Would you appreciate a PR with PHP 7.1 type declarations and strict_types declared in each file?

I think that TryCatchMiddleware::log() should not be private so I can extend it easily without copying the whole class.

What I'm trying to achieve is to log exception object under exception key in context because sentry's monolog handler expect the exception to be there so it can be fully logged to sentry including stacktrace and so.

• remove group middlewares
• remove router middleware
• remove filters

@f3l1x Don't you think it is a little bit misleading to "implement IMiddleware" in abstract class that is not actualy implementing any method?

Log all requests and responses.

I'm missing some real-life example or playground, something like to "how to start" or just link to some website.

For me, personally, the main problem is the first step. I will install the package, setup the index or bootstrap, but what next?

Does that mean that when I configure the List in the config.neon file then these middlewares will be automatically applied to all website requests? What can I do when I wnat some middleware to be applied just on some of them (eg. authentication middleware only for admin module).

Nice for apis - api should not redirect automatically if request came from http.

You known, to override the method.

When using Nette\SmartObject you no longer need to have that ::dispatch() method that only fires all anonymous functions in an array. The method name is maybe also a little bit misleading. Is usually stand for "transfer something to something else", for example and request..

Also, shouldn't it be called for example ::addOnError() instead of onError()?

• display middlewares in order they are used
• show which middleware returned response (if possible)

Hello,

I am not sure why PresenterMiddleware.php throws exception on line 111. I think if error presenter handles the exception we should just return $psr7Response converted from the error presenter result. If it's intentional how should I handle forming json request with an error inside the error presenter? return new JsonResponse gets tossed out.