contributte / gopay-simple Goto Github PK

In the code there is hard-coded CURLOPT_SSL_VERIFYPEER directive:
https://github.com/Markette/GopaySimple/blob/master/src/GopaySimple.php#L110

It should be removed and rewritten the way of explicit configuration.

a.
I think the simplest way will be public $curlOptions = [] property.
There I can set eg. $gopay->curlOptions[] = [CURLOPT_SSL_VERIFYPEER = FALSE] if I haven't certificates installed on my server and prefer currently hard-coded unsecure way.

b.
Better but longer way will be usage of some Curl wrapper instead of hard-coded curl calls.
I mean custom simple wrapper directly in the library or external library like https://packagist.org/packages/guzzlehttp/guzzle, https://packagist.org/packages/phpwrapper/curl, ...

Should I create a PR?